Fix modal confirms for 3.x #10478
Closed
Fix modal confirms for 3.x #10478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise the content can't be found anymore, as soon as the modal should be opened a second time
sgiehl
added
not-in-changelog
|
Seems this breaks UI for SitesManager admin. Guess we need to find another solution. I'll create a issue, so we don't forget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a modal confirm for a specific element, the element is currently moved into the modal box. Closing the box, doesn't move it back, so recreating won't work, as the content can't be found anymore.
With this small change the content is cloned before using it for modal confirm.
To reproduce the failure, simply try to remove a segment, click no, and try it again.
Note: Maybe we should refactor the modal confirm later. As closing modals doesn't remove the modal from dom.