Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New system check diagnostic for allow_url_include=on #10471

Closed
mattab opened this issue Sep 6, 2016 · 7 comments
Closed

New system check diagnostic for allow_url_include=on #10471

mattab opened this issue Sep 6, 2016 · 7 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Sep 6, 2016

I found out why plugins/marketplace times out for me. I have allow_url_include set to off in php.ini. You should add this to system file check page and let users know why they need it.

from https://forum.piwik.org/t/cron-archive-doesnt-work-plugins-timeout/20578/2

-> we could add a new system check to help users connect their Pwik server to the Internet and use the Marketplace.
@tsteur
Copy link
Member

tsteur commented Sep 8, 2016

👍

@mattab
Copy link
Member Author

mattab commented Sep 27, 2016

@sgiehl could you take a look at this one?

@mattab mattab added this to the 3.0.0 milestone Sep 27, 2016
@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. answered For when a question was asked and we referred to forum or answered it. labels Sep 27, 2016
@mattab mattab modified the milestones: 2.16.3, 3.0.0 Sep 27, 2016
@mattab mattab removed the answered For when a question was asked and we referred to forum or answered it. label Sep 27, 2016
@sgiehl
Copy link
Member

sgiehl commented Sep 27, 2016

Are you sure allow_url_include is required? Should allow_url_fopen not be enough?
Would need to do some testing if we really use include() or require() for external files.

Btw. default value for allow_url_include is 0, so guess it would fail on many systems then.

@mattab
Copy link
Member Author

mattab commented Sep 27, 2016 via email

@sgiehl
Copy link
Member

sgiehl commented Sep 27, 2016

As far as I've seen allow_url_include should not be required. Even allow_url_fopen shouldn't be required as long as curl or something else is available.
I'm not sure if such a check should be added. We already have a check for "open url", which should be enough for the marketplace, I guess?

@mattab
Copy link
Member Author

mattab commented Sep 29, 2016

The goal of this ticket is to make sure that, when an Internet connection is not possible, we explain in the System check how to configure PHP so that users will know how to enable internet connections. This is important for the marketplace connections and keeping users updated with the latest piwik release 👍

@mattab mattab modified the milestones: 2.17.0, 2.16.3 Sep 29, 2016
@mattab mattab modified the milestones: 3.0.0, 2.17.0 Oct 17, 2016
@Findus23
Copy link
Member

I'm pretty sure allow_url_include is not required by Matomo and should even be disabled for security reasons.

The explanation is already in https://matomo.org/faq/troubleshooting/faq_16646/ and adding a system check for failed API requests is tracked in #17308

@Findus23 Findus23 added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
4 participants
@tsteur @mattab @sgiehl @Findus23