Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when embedding reports, iframe to resize automatically to fit #10460

Closed
mejiasd3v opened this issue Sep 1, 2016 · 9 comments
Closed

when embedding reports, iframe to resize automatically to fit #10460

mejiasd3v opened this issue Sep 1, 2016 · 9 comments
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@mejiasd3v
Copy link

mejiasd3v commented Sep 1, 2016

Hi,

Is there a way I could edit the iframe template? I'd like to include iFrameResizer but I don't want to touch the source code. I was thinking in something like a plugin I could develop if you point me in the right direction (still didn't found something in the docs).

Thanks.

@mattab
Copy link
Member

mattab commented Sep 27, 2016

Hi @josemejiasji

I assume you are referring to the "Opt-out iframe"? or do you refer to some other iframes like when embedding analytics reports in your backoffice / application?

@mejiasd3v
Copy link
Author

Hi @mattab

The second one. I refer the embedding analytics' iframe.

@mattab
Copy link
Member

mattab commented Sep 27, 2016

@josemejiasji I think in this case it would be great if you test it, and if it works well, then we could

What do you think?

@mejiasd3v
Copy link
Author

mejiasd3v commented Sep 28, 2016

@mattab perfect!

I'll try it and then open a PR. In which branch should I work?

@mattab
Copy link
Member

mattab commented Oct 22, 2016

@josemejiasji FYI we're adding the iframe-resizer javascript project, into Piwik core in the PR: #10737 (for another reason). so it would be great to add your feature into core directly, and we now have the library you need(I think) already

@mattab
Copy link
Member

mattab commented Nov 11, 2016

Hi @josemejiasji did you have a chance to already look at iframe resizer?

@mattab mattab modified the milestones: Mid term, enh Nov 11, 2016
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Nov 11, 2016
@mattab mattab modified the milestones: Long term, enh Nov 11, 2016
@mattab mattab changed the title Edit iframe template when embeddig reports, the iframe resize automatically to fit Nov 12, 2016
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@mattab mattab modified the milestones: Backlog (Help wanted), 3.3.0 Nov 9, 2017
@mattab mattab changed the title when embeddig reports, the iframe resize automatically to fit when embedding reports, iframe to resize automatically to fit Nov 20, 2017
@Riegerman
Copy link

Riegerman commented Jan 30, 2019

Hi, I would like to ask if there is any solution to the problem, that when you open iframe window, you can not scroll down the reports, they are just cutted.

image

If I set in MS Edge, Firefox with developer tools scrolling=yes, then it works but only on these browshers i tried but not in Chrome.

image

Thanks, Daniel

@tsteur
Copy link
Member

tsteur commented Jan 30, 2019

@Riegerman thanks for suggestion, I'll create an issue to see if we can add this to the default recommended iframe markup

@mattab
Copy link
Member

mattab commented Dec 10, 2023

Thanks for contributing to this issue. As it has been a few months since the last activity and we believe this is likely not an issue anymore, we will now close this. If that's not the case, please do feel free to either reopen this issue or open a new one. We will gladly take a look again!

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

5 participants