New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when embedding reports, iframe to resize automatically to fit #10460
Comments
Hi @josemejiasji I assume you are referring to the "Opt-out iframe"? or do you refer to some other iframes like when embedding analytics reports in your backoffice / application? |
Hi @mattab The second one. I refer the embedding analytics' iframe. |
@josemejiasji I think in this case it would be great if you test it, and if it works well, then we could
What do you think? |
@mattab perfect! I'll try it and then open a PR. In which branch should I work? |
@josemejiasji FYI we're adding the iframe-resizer javascript project, into Piwik core in the PR: #10737 (for another reason). so it would be great to add your feature into core directly, and we now have the library you need(I think) already |
Hi @josemejiasji did you have a chance to already look at iframe resizer? |
Hi, I would like to ask if there is any solution to the problem, that when you open iframe window, you can not scroll down the reports, they are just cutted. If I set in MS Edge, Firefox with developer tools scrolling=yes, then it works but only on these browshers i tried but not in Chrome. Thanks, Daniel |
@Riegerman thanks for suggestion, I'll create an issue to see if we can add this to the default recommended iframe markup |
Thanks for contributing to this issue. As it has been a few months since the last activity and we believe this is likely not an issue anymore, we will now close this. If that's not the case, please do feel free to either reopen this issue or open a new one. We will gladly take a look again! |
Hi,
Is there a way I could edit the iframe template? I'd like to include iFrameResizer but I don't want to touch the source code. I was thinking in something like a plugin I could develop if you point me in the right direction (still didn't found something in the docs).
Thanks.
The text was updated successfully, but these errors were encountered: