When generating a new plugin component, make sure to generate correct piwik version require #10457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
the
not-in-changelog
tsteur
added a commit
that referenced
this pull request
Sep 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In plugin.json we used to generate piwik require only ">=3.0.0-b1" but now we require eg ">=3.0.0-b1,<4.0.0-b1" when generating a plugin. Meaning we make sure to specify an upper limit.
When generating any plugin component we update the required piwik version in plugin.json automatically and set it to the current used Piwik version as users likely don't test it with older Piwik versions. We now generate a version constraint like ">=3.0.0-b1,<4.0.0-b1" as well and we only update it, if the developer is actually using that version format and not if a developer has defined a custom version constraint.