Remove deprecated events #10455
Merged
Remove deprecated events #10455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,6 +84,7 @@ Read more about migrating a plugin from Piwik 2.X to Piwik 3 on our [Migration g | |||
| * The JavaScript AjaxHelper has a new method `ajaxHelper.withTokenInUrl()` to easily send a token along a XHR. Within the Controller the existence of this token can be checked via `$this->checkTokenInUrl();` to prevent CSRF attacks. | |||
| * The new class `Piwik\Updater\Migration\Factory` lets you easily create migrations that can be executed during an update. For example database or plugin related migrations. To generate a new update with migrations execute `./console generate:update`. | |||
| * The new method `Piwik\Updater::executeMigration` lets you execute a single migration. | |||
| * New event `ViewDataTable.filterViewDataTable` let's you filter available visualizations | |||
There was a problem hiding this comment.
I removed the old ViewDataTable.addViewDataTable and replaced it with ViewDataTable.filterViewDataTable. In general we always want to add components via the PHP files and to filter things we always use events. The ViewDataTable.filterViewDataTable is used and needed by Treemap plugin but will be also useful for other plugins
|
When merging we also need to create a PR and merge matomo-org/plugin-CustomDimensions@3.x-dev...8503 . It was not trivial to remove all deprecated events but most are removed. The failing screenshot tests are not related to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8503
replaces #8620
The 2 failing UI tests are rather random build errors: http://builds-artifacts.piwik.org/piwik/piwik/8503/14940/ We might have to update those screenshots after merging.
It was not as easy as simply removing all events as some were still in use. I already adjusted treemap plugin to be compatible with 2.X and 3.X