shorten getController function #10445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorten getController function before it gets out of hand
| $controller = $this->createReportMenuController($module, $action, $parameters); | ||
| if ($controller) { | ||
| return $controller; | ||
| foreach(['Plugin', 'Widget', 'Report', 'ReportMenu'] as $controler) { |
There was a problem hiding this comment.
Short array notation is not compatible with PHP 5.3, but Piwik 2.x still is. We can do it that way for Piwik 3.x
|
@PabloJoan thank you for the PR 👍 I'd personally prefer how it is done currently as it allows us to use refactoring tools in the IDE, auto completion for this functions, "find usage" feature in IDE etc. Not a huge fan of such tweaks while it's shorter it removes readability etc. Not sure what others think |
mattab
added
the
answered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please issue pull request against the
3.x-devbranch as themasterbranch currently represents our2.Xversion which is in LTS mode.Important fixes will be merged into
masterif needed after it was merged to3.x-dev.shorten getController function before it gets out of hand