@stweil opened this Pull Request on August 23rd 2016 Contributor

Ending lines with CRLF is only useful for pure Windows files.

Signed-off-by: Stefan Weil sw@weilnetz.de

@mattab commented on September 27th 2016 Member

@stweil could you maybe apply this to all other files that don't have proper line endings?

@stweil commented on September 27th 2016 Contributor

The remaining ones with CRLF belong to pChart. If you want, I can sent a pull request for those files as well (also against branch 3.x-dev?).

@mattab commented on September 27th 2016 Member

Yes would be great thanks. We also need to add a test to releasechecklist
test file to prevent committing files with cord in the future. If you want
to do this as well, would be great

Matthieu

On 28/09/2016 2:35 am, "Stefan Weil" notifications@github.com wrote:

The remaining ones with CRLF belong to pChart. If you want, I can sent a
pull request for those files as well (also against branch 3.x-dev
https://github.com/piwik/piwik/tree/3.x-dev?).


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/piwik/piwik/pull/10435#issuecomment-249866375, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAcfTQ8tchD1YlrapHY5tLZiJZ-bsITYks5quRuVgaJpZM4JrWqn
.

@stweil commented on September 28th 2016 Contributor

The pChart files are fixed by PR #10591. I'll have a look at the test needed for continuous integration later (probably not this week).

This Pull Request was closed on September 23rd 2016
Powered by GitHub Issue Mirror