Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPLv3: Replace line end characters from CRLF to LF #10435

Merged
merged 1 commit into from Sep 23, 2016
Merged

GPLv3: Replace line end characters from CRLF to LF #10435

merged 1 commit into from Sep 23, 2016

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Aug 23, 2016

Ending lines with CRLF is only useful for pure Windows files.

Signed-off-by: Stefan Weil sw@weilnetz.de

@stweil
GPLv3: Replace line end characters from CRLF to LF
e49ec1d 
Ending lines with CRLF is only useful for pure Windows files.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@mattab mattab merged commit 1de039a into matomo-org:3.x-dev Sep 23, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 23, 2016
@mattab mattab added this to the 3.0.0-b1 milestone Sep 23, 2016
@mattab
Copy link
Member

mattab commented Sep 27, 2016

@stweil could you maybe apply this to all other files that don't have proper line endings?

@stweil
Copy link
Contributor Author

stweil commented Sep 27, 2016

The remaining ones with CRLF belong to pChart. If you want, I can sent a pull request for those files as well (also against branch 3.x-dev?).

@mattab
Copy link
Member

mattab commented Sep 27, 2016

Yes would be great thanks. We also need to add a test to releasechecklist
test file to prevent committing files with cord in the future. If you want
to do this as well, would be great

Matthieu

On 28/09/2016 2:35 am, "Stefan Weil" notifications@github.com wrote:

The remaining ones with CRLF belong to pChart. If you want, I can sent a
pull request for those files as well (also against branch 3.x-dev
https://github.com/piwik/piwik/tree/3.x-dev?).

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#10435 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAcfTQ8tchD1YlrapHY5tLZiJZ-bsITYks5quRuVgaJpZM4JrWqn
.

@stweil
Copy link
Contributor Author

stweil commented Sep 28, 2016

The pChart files are fixed by PR #10591. I'll have a look at the test needed for continuous integration later (probably not this week).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stweil @mattab