Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoreHome Integration tests error #10432

Closed
wronan opened this issue Aug 23, 2016 · 1 comment
Closed

CoreHome Integration tests error #10432

wronan opened this issue Aug 23, 2016 · 1 comment
Labels
answered For when a question was asked and we referred to forum or answered it.

Comments

@wronan
Copy link
Contributor

wronan commented Aug 23, 2016

This:
https://github.com/piwik/piwik/blob/master/plugins/CoreHome/tests/Integration/Tracker/VisitRequestProcessorTest.php#L113
should rather be
$dim = $this->getMock('Piwik\\Plugin\\Dimension\\VisitDimension', array('shouldForceNewVisit', 'getColumnName'));
@mattab
Copy link
Member

mattab commented Aug 24, 2016

Should be fixed in Piwik 3 already, and build is green on master as we now use an older phpunit as specified in the composer.json

@mattab mattab closed this as completed Aug 24, 2016
@mattab mattab added the answered For when a question was asked and we referred to forum or answered it. label Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
answered For when a question was asked and we referred to forum or answered it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @wronan