Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoNotTrack: Tk response header value wrong #10427

Closed
andrewbrown12 opened this issue Aug 23, 2016 · 1 comment
Closed

DoNotTrack: Tk response header value wrong #10427

andrewbrown12 opened this issue Aug 23, 2016 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@andrewbrown12
Copy link
Contributor

andrewbrown12 commented Aug 23, 2016

When the DNT request header value is set to 1, the response header from Piwik is set to 1

Example request header:
Accept:image/webp,image/*,/;q=0.8
Accept-Encoding:gzip, deflate, sdch, br
Accept-Language:en-US,en;q=0.8
Cache-Control:no-cache
Connection:keep-alive
DNT:1
Host:myhost.co.uk
Pragma:no-cache
Referer:hmyhost.co.uk/
User-Agent:Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36

Example response header:
Connection:keep-alive
Content-Length:0
Content-Type:text/html; charset=UTF-8
Date:Wed, 17 Aug 2016 13:29:20 GMT
P3P:CP='OTI DSP COR NID STP UNI OTPa OUR'
Strict-Transport-Security:max-age=63072000; includeSubdomains; preload
Tk:1

1 is not a valid value for Tk see here for more information https://www.w3.org/2011/tracking-protection/drafts/tracking-dnt.html#TSV-defn

Tk should be N when DNT is set

@andrewbrown12
Copy link
Contributor Author

Pull request #10428 submitted

@tsteur tsteur added this to the 2.16.3 milestone Aug 31, 2016
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Aug 31, 2016
@mattab mattab changed the title Tk response header value wrong DoNotTrack: Tk response header value wrong Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants