Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.htaccess files not being generated? #10420

Closed
mikerockett opened this issue Aug 20, 2016 · 2 comments
Closed

.htaccess files not being generated? #10420

mikerockett opened this issue Aug 20, 2016 · 2 comments
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@mikerockett
Copy link

mikerockett commented Aug 20, 2016

I've just started using Piwik on a cloud server, and it appears that the installation did not create the needed .htaccess files. As a result, all directories are indexable.

The public folder has all the necessary permissions where my user (owner) and the apache user (group) can write.

Is there any way I can have these files generated, and why did they not generate in the first place? Better yet, why are these files not included by default anyway? I'm sure a simple .htaccess in the root would have sufficed, instead of one for each directory (I think that's what the generator does?)...

Edit: I also think the security module should warn users when these files do not exist.

Update: I have now generated these files by calling the relevant method from index.php (deleted now as this is a once-off thing).

Piwik\Plugins\Installation\ServerFilesGenerator::createHtAccessFiles();

I also noted from a GH search that this method is only called when running updates, but never at install-time. Is this an oversight?

@mattab
Copy link
Member

mattab commented Aug 22, 2016

Hi @mikerockett
We have fixed this issue recently in PR: #10414 which will be merged for in 2.16.3. Feel free to test the PR. Thanks for the report!

@mattab mattab closed this as completed Aug 22, 2016
@mattab mattab added the duplicate For issues that already existed in our issue tracker and were reported previously. label Aug 22, 2016
@mikerockett
Copy link
Author

👍 Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Development

No branches or pull requests

2 participants