Remove a var_dump /exit #10410
Closed
Remove a var_dump /exit #10410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
the
not-in-changelog
|
LGTM |
| private function shouldReportBeIgnored($reportMetadata) | ||
| { | ||
| // Some plugins may not define report categories | ||
| if(empty($reportMetadata['category'])) { |
|
ideally no merge of this before we haven't merged the UI PR |
| $reportMetadata['category'] == 'API' || | ||
| $reportMetadata['category'] == Piwik::translate('General_MultiSitesSummary') && $reportMetadata['name'] == Piwik::translate('General_SingleWebsitesDashboard') | ||
| ) { | ||
| if ($this->shouldReportBeIgnored($reportMetadata)) { |
There was a problem hiding this comment.
Can you add a unit or an integration test for this method getReportMetadata?
|
There is now a merge conflict. I think I have removed the var_dump as well when I made the tests green for the Piwik 3 UI branch |
|
Already fixed in 3.x-dev branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
along with a tiny refactor