Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the updates generated by generate:update command work #10409

Closed
wants to merge 1 commit into from

Conversation

mattab
Copy link
Member

@mattab mattab commented Aug 16, 2016

No description provided.

@mattab mattab added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Aug 16, 2016
@mattab mattab added this to the 3.0.0-b1 milestone Aug 16, 2016
@tsteur
Copy link
Member

tsteur commented Aug 30, 2016

This breaks generating update files for core via eg ./console generate:update --component=core which it is mostly used for I'd say.

I'd undo that change and instead in GenerateUpdate remove

        if ($component !== 'core') {
            $className .= '\Updates';
        }

Which should work

@mattab
Copy link
Member Author

mattab commented Aug 31, 2016

@tsteur sounds good to me - maybe double check that it works for generate:update for a plugin, or let me know when it's done and i'll check

@mattab mattab closed this Aug 31, 2016
@tsteur
Copy link
Member

tsteur commented Aug 31, 2016

fixed it here #10456

@tsteur tsteur deleted the fix_generate_update branch August 31, 2016 20:10
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants