Activating a plugin should fail when the plugin has missing dependencies #10401
Conversation
For example via plugin:activate console command. without this patch it looks like the plugin:activate worked but it didn't
| * @param $plugin Plugin | ||
| * @throws \Exception | ||
| */ | ||
| private function throwIfPluginMissingDependencies($plugin) |
There was a problem hiding this comment.
Can you maybe move this method in another class and make it public so it can be tested? the string formatting part might be also useful for plugins/CorePluginsAdmin/templates/macros.twig and https://github.com/piwik/piwik/blob/2.16.2/core/Plugin/Manager.php#L831 where it should be actually deactivated the plugin even before we try to install I think
|
Added the text to the notification: The twig code now reuses the PHP logic Added test for the new method |
|
|
||
| $causedBy = array(); | ||
| foreach ($missingDependencies as $dependency) { | ||
| $causedBy[] = strtoupper($dependency['requirement']) . ' ' . $dependency['causedBy']; |
There was a problem hiding this comment.
I think this should be rather capitalize instead of strtoupper. There will be also plugin names etc. For PHP we have in the Marketplace a special if to convert it to upper case
Conflicts: libs/bower_components/jquery.scrollTo/README.md libs/bower_components/jquery.scrollTo/jquery.scrollTo.min.js libs/bower_components/jquery.scrollTo/scrollTo.jquery.json plugins/CorePluginsAdmin/lang/en.json plugins/CorePluginsAdmin/templates/macros.twig
|
Will re-create the PR clean, as I included submodules by mistake |
mattab
added
the
duplicate
Bug: when using
plugin:activateconsole command: without this patch it looks like the plugin:activate worked but it didn't