Changed empty tracker response message #10395
Conversation
* Indicate some context for the message * Added rel=`nofollow` to stay on the good side of Google
| @@ -78,7 +78,7 @@ public function outputResponse(Tracker $tracker) | |||
| Common::sendResponseCode(400); | |||
| } | |||
| Common::printDebug("Empty request => Piwik page"); | |||
| echo "<a href='/'>Piwik</a> is a free/libre web <a href='http://piwik.org'>analytics</a> that lets you keep control of your data."; | |||
| echo 'This resource is part of <a href="https://piwik.org/" rel="nofollow">Piwik</a>, a free/libre web analytics tool that lets you keep control of your data.'; | |||
There was a problem hiding this comment.
I think @mattab will want to have the link without the rel="nofollow". Otherwise looks good to me. 👍
There was a problem hiding this comment.
See the link provided in the initial commit message. Google doesn’t want links like this without the rel=nofollow attribute. Violates Google’s link scheme policy: “low-quality links embedded in widgets that are distributed across various sites”
|
Google just published A reminder about widget links. So yeah, nofollow or no link. |
|
I'd be ok with that (nofollow). ping @mattab |
|
@Aeyoun could you remove the first link and leave the second one to piwik.org? Clearly the link is nowhere spammy as piwik.org is high quality website. It is actually helpful to show this message and a link in the tracking API endpoint as it is helpful to people wondering what this endpoint is. google would not consider our link in their definition "of keyword-rich, hidden or low-quality links embedded in widgets that are distributed across various sites." <- clearly that's not us 👍 |
|
@mattab, no but you’re missing the intention of Google’s policy there. Automatically distributed links like this one should use |
|
I definitely understand your point and also why Gogle does this. I feel like Google will never penalise us for linking in our API endpoint to the official website of the API/ Product, as they clearly refer to other practises in their public communication (spammy links, within the content of the website, which is not the case for this link as it never shows up in the content itself). Either way I think we could put the |
|
Fixed in 3.0.0-beta2: fixed text, making link SSL and fixing tests. (didn't add nofollow as linking to piwik.org is not seens as spammy by google) |
Google don’t like the link scheme currently deployed by Piwik. It’s considered quite spammy. It doesn’t help that there are two links, one of which is broken.
This patch adds a slightly more meaningful error response message, and adds HTTPS and a nofollow attribute to the link.