Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SEO Metrics: make all metrics work and remove pagerank which was deprecated #10393

Merged
merged 4 commits into from Oct 30, 2016
Merged

Update SEO Metrics: make all metrics work and remove pagerank which was deprecated #10393

merged 4 commits into from Oct 30, 2016

Conversation

pebosi
Copy link
Contributor

@pebosi pebosi commented Aug 11, 2016

The only working metric was Alexa, so i updated the others to work again.

@pebosi
Fix language
9e673d4
@pebosi
simplify
3e67a29
@pebosi
Remove pagerank, fix pagecount
d5cc161 
pagerank query is dead for a long time, pagecount is sometimes with a dot.
@pebosi
New regex
77c213a
@mattab
Copy link
Member

mattab commented Aug 11, 2016

Hi @pebosi
thank you for the Pull request and fixing these issues!

Why did you remove the pagerank metric?

@pebosi
Copy link
Contributor Author

pebosi commented Aug 12, 2016

Google has shutdown the public Pagerank. it's always 0 for all sites.
More info: http://searchengineland.com/google-has-confirmed-they-are-removing-toolbar-pagerank-244230

@mattab
Copy link
Member

mattab commented Aug 16, 2016

Google has shutdown the public Pagerank. it's always 0 for all sites.

so it makes sense to remove it for sure!

we should check that the PR does not introduce regression: some of the other metrics you fixed (Bing, domain age) seem to work currently for "piwik.org" domain ie.
untitled

What domain names were these metrics not working for you?

@mattab mattab added the Needs Review PRs that need a code review label Aug 16, 2016
@mattab mattab added this to the 3.0.0 milestone Aug 16, 2016
@pebosi
Copy link
Contributor Author

pebosi commented Aug 16, 2016

Not working for pebosi.net, google.de, many others.
The reason for this is the User-Agent which is transferred to the Metric Urls, which contains my locale "de-DE". So my changes are just to make sure the queries use correct lang paramerters or to handle both dots and comma.

Only DMOZ was not working at all.
Am 16. August 2016 um 06:47:17 +02:00, hat Matthieu Aubry notifications@github.com geschrieben:

Google has shutdown the public Pagerank. it's always 0 for all sites.
so it makes sense to remove it for sure!
we should check that the PR does not introduce regression: some of the other metrics you fixed (Bing, domain age) seem to work currently for "piwik.org" domain ie. untitled https://cloud.githubusercontent.com/assets/466765/17688173/ccb50c8c-63d0-11e6-9e2a-fc9843ff140f.png
What domain names were these metrics not working for you?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #10393 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAbK-9Xd4sHiBcKQvH6un_26KPhXuFuMks5qgUDVgaJpZM4JiIvI.

@tsteur
Copy link
Member

tsteur commented Aug 30, 2016

@pebosi I'd be happy to merge this but the change would be needed for Piwik 3. Do you mind creating this PR for the "3.x-dev" branch? I don't think anything has changed in SEO in Piwik 3 so it should be straight forward hopefully. Let me know if there's any trouble

@tsteur tsteur closed this Aug 30, 2016
@mattab mattab changed the base branch from master to 3.x-dev September 27, 2016 04:19
@mattab mattab reopened this Sep 27, 2016
@mattab mattab modified the milestones: 3.0.0-b2, 3.0.0 Sep 27, 2016
@mattab
Copy link
Member

mattab commented Sep 27, 2016

Since Github lets use change the base branch, i've changed it to 3.x-dev and we'll review this for 3.0.0

@pebosi
Copy link
Contributor Author

pebosi commented Oct 14, 2016

Is there something to do?

@tsteur
Copy link
Member

tsteur commented Oct 30, 2016

Thanks for this 👍 Tested it and worked for me.

@tsteur tsteur merged commit 3018d07 into matomo-org:3.x-dev Oct 30, 2016
@mattab mattab changed the title Update SEO Metrics Update SEO Metrics: make all metrics work and remove pagerank which was deprecated Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.0.0-b2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pebosi @mattab @tsteur