Add icon for pinned tabs in Safari #10385
Conversation
|
I don't know, why some of the test failed. But some of them doesn't failed because of my changes. For example the tests with the screenshots could not fail, because I changed nothing on the UI. |
| "http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" version="1.0" viewBox="0 0 16 16"> | ||
|
|
||
| <g transform="translate(0 500) scale(0.1 -0.1)" fill="#000000" stroke="none"> |
There was a problem hiding this comment.
The color should be ideally #d4291f
|
I'm pretty sure the failing tests are not related to your change. I commented on the color and will try to test it in the next days |
|
Thanks for creating the PR! 👍 |
| @@ -1,4 +1,4 @@ | |||
| {% if isCustomLogo and customFavicon is defined and customFavicon %} | |||
| {% else %} | |||
| <link rel="mask-icon" href="plugins/CoreHome/images/applePinnedTab.svg" color="#C81319"> | |||
| <link rel="mask-icon" href="plugins/CoreHome/images/applePinnedTab.svg" color="#d4291f"> | |||
There was a problem hiding this comment.
The svg image must be completely black. The color is written into in the HTML-Head. Here some more information about the Tab Icon: Apple Developer Library
|
I changed the color. |
|
I have not forgotten you. I will merge in a couple of days as I first need to merge another big PR to avoid merge issues. |
mattab
added
the
Enhancement
|
Thanks @vekunz Just tested it in Safari and works great! |
The browser Safari supports pinned tabs since version 9, but you need a special icon for this tab. Otherwise only a default icon is shown, and not the favicon.