Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook allowing to prevent certain plugins archiving #10367

Closed
mgazdzik opened this issue Aug 3, 2016 · 1 comment
Closed

Add hook allowing to prevent certain plugins archiving #10367

mgazdzik opened this issue Aug 3, 2016 · 1 comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@mgazdzik
Copy link
Contributor

mgazdzik commented Aug 3, 2016

Goal of this issue is to add functionality allowing to prevent certain plugins archiving on the fly (during archiver run).

Currently it is only possible to prevent given plugin archiving by disabling it entirely.
However for performance reasons it might be beneficial to prevent heavy plugin archiving under some circumstances to allow archiving run till the end (for ex. prevent actions plugin archiving, but allow remaining to process their data).
Basically such decision could be done based on plugin name and archiving parameters.

After core code review I have found no possibility to do this in nice way but to add new hook in PluginsArchiver class.

MR for that feature is available at #10366

Please let me know if such approach is acceptable in core, or should such feature be provided in different way?

@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. labels Aug 3, 2016
@mattab
Copy link
Member

mattab commented Oct 2, 2016

Done in #10366

@mattab mattab closed this as completed Oct 2, 2016
@mattab mattab added this to the 2.16.3 milestone Oct 2, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

3 participants