World Map update (Lesotho, Palestine) #10352
Conversation
This change merges Gaza and the West Bank into Palestine and makes sure that visit numbers are displayed on the world and continental map levels.
Fixes Lesotho being hidden by moving it above South Africa. This only works when visits from Lesotho have been recorded.
|
Did you fix/update the SVGs manually? We used to had a script for that, but it doesn't work anymore... |
|
Yes, I updated them manually. Also, where can I find this script? Maybe I'm able to figure out why it doesn't work. |
|
It's an old python script (https://github.com/piwik/piwik-map-generator). The used map data has changed. Tried to get it working with the new ones, but my knowledge about python, shapefiles and geodata is limited. |
|
The map generator seems to have been neglected for some time. The effort required for updating it will definitely exceed the cost of just manually fixing the small issues which currently exist in the map. |
|
@polyfloyd thanks for having a look into it. I'll have a closer look at
your PR so we can merge it afterwards.
Btw. are you familiar with svg maps, shape files and stuff like that? Maybe
you would be keen to build a new tool with us to generate svg maps for
Piwik. If so please get in touch with us by mail hello@piwik.org
Would be awesome to have a new maintained tool for that!
|
|
FYI: we would need to have this PR against the "3.x-dev" branch instead of "master" as we only merge critical bugfixes and security fixes into "master" as Piwik 2 is in LTS mode. I will close this but would be highly appreciated if you could issue the PR again. @sgiehl have you had a look at the maps already? |
|
So uh, does changing the base of this PR work or do you prefer me opening a new PR? |
|
@polyfloyd Switching the base should be enough. |
|
@sgiehl Could you take a quick look at this PR and whether we can merge it in beta1/beta2? |
|
Had a closer look at the changes. For me the changes look ok. But I'm not sure if the other occurrences of |
|
IIRC those other GAZ'es are present in images where Gaza is outside of the SVG viewport, e.g. North and South America. |
|
Ok. but wouldn't it be more consistent to change it everywhere? |
|
Good point. Although it seems that the remaining GAZ and WEB's were parts of Palestine that are displayed in the views of neighbouring countries. That's worth fixing. |
|
ok fine. guess that should be good to merge then |
This update fixes the appearance of some countries in the UserCountryMap plugin.
The ISO3 codes for Gaza, West Bank and South Sudan have been updated so the number of visits are correctly displayed.
Additionally, Gaza and the West Bank have been merged into a single Palestine.
The enclaved country of Lesotho is still covered by South Africa, but will now be visible when visits have been recorded.