Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible plugin notification only names one plugin #10351

Closed
Croydon opened this issue Jul 29, 2016 · 4 comments
Closed

Incompatible plugin notification only names one plugin #10351

Croydon opened this issue Jul 29, 2016 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
Backlog (Help wan...

Comments

@Croydon
Copy link

Croydon commented Jul 29, 2016

If Piwik detects incompatible plugins it displays a warning message.
However, even the message itself is written in plural form only one plugin is randomly(?) named, even there are serveral plugins incompatible as one can see on the manage plugins site.

Just a minor bug, but it should still list all incompatible plugins.

piwikplugins

Piwik 2.16.1, PHP 7
@tsteur
Copy link
Member

tsteur commented Jul 30, 2016

It should list all incompatible plugins. Can you post a screen of the "manage plugins" page where it lists more invalid plugins? Or which plugins is it reporting as invalid?

Maybe we are missing a call to isManifestFileFound here: https://github.com/piwik/piwik/blob/2.16.1/core/Plugin/Manager.php#L1049

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jul 30, 2016
@Croydon
Copy link
Author

Croydon commented Jul 30, 2016

@tsteur Incompatible are: ExampleFeedburner, SecurityInfo (which is in the message) and VisitorGenerator.

@tsteur
Copy link
Member

tsteur commented Jul 30, 2016

For ExampleFeedburner it could be indeed the missing manifest file while there should be one provided for VisitorGenerator unless it is a very old version. Thanks for getting back so quickly

@tsteur tsteur added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Jul 30, 2016
@mattab mattab modified the milestones: 3.0.0, Mid term Nov 11, 2016
@Croydon
Copy link
Author

Croydon commented Jan 11, 2020

I personally no longer use Matomo and could not reproduce this anyway.

The issue was also not a major one

And I would assume that missing manifest files in plugins might be a legacy thing, which only happens with (in the meantime) very, very old plugins.

Closing

@Croydon Croydon closed this as completed Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@tsteur @mattab @Croydon