Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tooltip for pages without Title or highlight them #10347

Open
blueelvis opened this issue Jul 26, 2016 · 4 comments
Open

Add a tooltip for pages without Title or highlight them #10347

blueelvis opened this issue Jul 26, 2016 · 4 comments
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@blueelvis
Copy link
Contributor

I modified my test website's HTML page so that it did not have any Title tag inside the Head tag.
I then visited the following -
Website -> Actions -> Page Titles

And I got this message - Page Name not defined

I think that this could either have a tooltip or some highlight that this is not a page title but rather something else. If we add the tooltip, we could even add some help of adding the page's title.

Reference Screenshot -
screenshot 7

@tsteur
Copy link
Member

tsteur commented Jul 30, 2016

That would be helpful indeed 👍

@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Jul 30, 2016
@blueelvis
Copy link
Contributor Author

@tsteur - Could you please guide me on how I could get started with this one?

@tsteur
Copy link
Member

tsteur commented Aug 1, 2016

I think this part is rendered here: https://github.com/piwik/piwik/blob/2.16.1/plugins/CoreHome/templates/_dataTableCell.twig#L44 which means it is possible to configure a view property that defines which metadata name contains the tooltip with something like this:

$view->config->tooltip_metadata_name = 'myTooltipMetadataName';

here: https://github.com/piwik/piwik/blob/2.16.1/plugins/Actions/Reports/GetPageTitles.php#L71

Then we would only need to set eg on that row the metadata $row->setMetadata('myTooltipMetadataName', 'This page does not have a title...'). This part would be usually straight forward, however the Actions plugin is quite messy and needs to be updated some day.

@mattab do I see this right that the label for this gets row gets actually archived in https://github.com/piwik/piwik/blob/2.16.1/plugins/Actions/ArchivingHelper.php#L380 and then https://github.com/piwik/piwik/blob/2.16.1/plugins/Actions/ArchivingHelper.php#L406 ?

@mattab mattab added this to the Mid term milestone Nov 11, 2016
@mattab
Copy link
Member

mattab commented Nov 11, 2016

Hi @blueelvis maybe you have a chance to look at Thomas feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

3 participants