Fix Scheduled Reports sent one hour late in daylight saving timezones #10318
Conversation
sgiehl
added
not-in-changelog
| @@ -29,11 +29,16 @@ function formSetEditReport(idReport) { | |||
|
|
|||
| toggleReportType(report.type); | |||
|
|
|||
| var hour = (24 + parseInt(report.hour) - timeZoneDifference) % 24; | |||
There was a problem hiding this comment.
this little logic can be refactored in a method
|
Hi @sgiehl - Good find! Review:
|
It uses the Model of ScheduledReports plugin, which should already be tested... |
|
I was wondering as well if there's a chance to create some tests for it but likely already kind of tested. Have you checked if maybe other scheduled reports have a similar issue? |
|
Mobile messaging uses the same codebase for sending the reports, so the issue should then be fixed there, as well |
| $dateTimeZone = new \DateTimeZone($timezone); | ||
|
|
||
| $timeZoneDifference = -ceil($dateTimeZone->getOffset(new \DateTime()) / 3600); | ||
| $report['hour'] += $timeZoneDifference; |
There was a problem hiding this comment.
needs to be replaced with $report['hour'] = (24 + $report['hour'] + $timeZoneDifference) % 24;
to ensure the number doesn't become negative
|
Hi @adaqus Did you review this Pull request and could you please confirm it works for you? ie. that it fixes the existing reports as expected, as well as fixes the issue for newly created reports? |
|
I will replace this PR with a new one, as the source repo doesn't exist anymore. |
This PR aims to fix the issue, that scheduled reports might be sent one hour to late / to early if the reports are saved for an site having a timezone using daylight savings.
The problem occurs because the "hour" the report should be sent at is currently saved in the timezone of the site. That means a new report with the timezone like e.g.
Europe/Berlinwith the setting to send the report at 8 o'clock would be one hour earlier/later when the daylight saving changes.Internal Piwik uses UTC for running the tasks, so it tries to adjust the saved hour using the site's timezone difference. At the moment that would be two hours for
Europe/Berlin, so the report would sent at 6 o'clock UTC. When the daylight saving changes again, the timezone difference will be only an hour. So Piwik will then reduce the saved hour value only by one to get the UTC time, which will be 7 o'clock (which is one hour later).To avoid this in the future, I changed the current behavior to not save the hour value in the site's timezone anymore, but to use the UTC time instead. Doing this, the value can't be affected by daylight saving anymore. I also added an update script to update existing reports to have UTC values.
When creating/editing an report for an site using a timezone with a difference to UTC, Piwik will now should the UTC, aswell:
fixes #7658, refs #5873