Fixed the X-Frame bug #10317
Fixed the X-Frame bug #10317
Conversation
Maybe you didn't push your changes to Github / remote, and only pushed your changes to your local git repo? |
| // Adapters recommended by Piwik. Needs to be in uppercase for string checking using in_array() | ||
| 'PDO\MYSQL' | ||
| ); | ||
| if(in_array($adapterName,$recommendedAdapters)) { |
There was a problem hiding this comment.
you can simply do return in_array(...);
|
Thanks for the PR, left a few comments. |
blueelvis
changed the title
|
@mattab - Separated the code. Pushed the changes. Please check :) |
|
@mattab the changes were made, can we merge this one? |
| } | ||
| if ($option == 'allow') { |
There was a problem hiding this comment.
@blueelvis I don't think this code should be removed, since it's still used in https://github.com/piwik/piwik/blob/2.16.2/plugins/CoreAdminHome/OptOutManager.php#L203 and https://github.com/piwik/piwik/blob/master/plugins/Widgetize/Controller.php#L47-47
mattab
added
Pull Request WIP
|
Hi @blueelvis Because it was last updated more than one month ago, it is our policy to close pull requests opened for a long time without updates. If you would like to continue work on the pull request, please simply ping us to have it re-opened (after you have pushed a new commit). We hope you understand this and we look forward to seeing an update from you on this pull request or another one! Thanks. |
This is regarding this pull request.
#10284
For some unknown reason, Github is not updating that PR with the commits so had to create a new pull request :(
If anyone has any idea what went wrong, please do let me know :)