Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-process even "real time" segments, when archiving of segment is enforced via browser_archiving_disabled_enforce=1 #10309

Closed
wants to merge 1 commit into from
Closed

Pre-process even "real time" segments, when archiving of segment is enforced via browser_archiving_disabled_enforce=1 #10309

wants to merge 1 commit into from

Conversation

mattab
Copy link
Member

@mattab mattab commented Jul 15, 2016 •
edited

To do:

  • fix this PR (the logic is broken)
  • write test
  • announce in CHANGELOG.md as it may create extra core:archive load after upgrade

Fixes #10307

@mattab
Pre-process even "real time" segments, when archiving of segment is e…
78e65fb 
…nforced via browser_archiving_disabled_enforce=1

Fixes #10307
@mattab mattab added the Needs Review PRs that need a code review label Jul 15, 2016
@mattab mattab added this to the 2.16.2 milestone Jul 15, 2016
@mattab mattab mentioned this pull request Jul 15, 2016
Merged
@mattab mattab added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. and removed Needs Review PRs that need a code review labels Jul 15, 2016
@mattab mattab modified the milestones: 2.16.x (LTS), 2.16.2 Jul 15, 2016
@mattab mattab closed this Jul 18, 2016
@mattab
Copy link
Member Author

mattab commented Jul 18, 2016

This code is not working, so closing.

@mattab mattab deleted the 10307 branch October 4, 2016 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Milestone
2.16.x (LTS)
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mattab