Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the JS library (fdd2div) used in Website and Language selector #1030

Closed
robocoder opened this issue Oct 31, 2009 · 6 comments
Closed

Replace the JS library (fdd2div) used in Website and Language selector #1030

robocoder opened this issue Oct 31, 2009 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@robocoder
Copy link
Contributor

Issues:

Proposal:

  • adopt Filament Group's jquery-ui plugin "selectmenu"

Note: I have not yet looked at #288, to see if/how this fits in...
@mattab
Copy link
Member

mattab commented Feb 19, 2010

Is this still something we want to do or do we instead wait for a new Menu all together (for example something like in #1048 ?)

@robocoder
Copy link
Contributor Author

fdd2div is used by the Language and Site selector. This is not addressed by #1048.

@mattab
Copy link
Member

mattab commented Mar 2, 2010

OK thanks for clarification. How much effort is this? Otherwise, we can wait until we need to modify something in the menu. would vote for wontfix

@robocoder
Copy link
Contributor Author

If we're going to defer, I'd rather we keep it open and simply move to a different milestone.

@robocoder
Copy link
Contributor Author

The current markup used to layout the language selector causes the document to not pass the w3c validator.

And the markup and/or fdd2div code means we can't "click" on a language during a WebTest.

@robocoder
Copy link
Contributor Author

Fixed in #2415 !!! Yay Steve !!!

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
@robocoder robocoder mentioned this issue May 5, 2010
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattab @robocoder