Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users track ecommerce orders with the same SKU multiple times (fix in JS SDK, PHP SDK) #10297

Closed
wants to merge 4 commits into from

Conversation

mattab
Copy link
Member

@mattab mattab commented Jul 13, 2016

@mattab mattab added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jul 13, 2016
@mattab mattab self-assigned this Jul 13, 2016
@mattab mattab added this to the 2.16.2 milestone Jul 13, 2016
@mattab mattab modified the milestones: 3.0.0, 2.16.2 Jul 14, 2016
@mattab
Copy link
Member Author

mattab commented Jul 14, 2016

At the moment in Piwik the Tracking API backend does expect at most one product with a given SKU, as there is a PRIMARY KEY(idvisit, idorder, idaction_sku), on log_ecommerce_item table.

As we are in LTS we cannot change the schema of any log_* table, therefore moving this issue to 3.0 milestone.

@tsteur tsteur changed the base branch from master to 2.x-dev September 1, 2016 06:38
@mattab
Copy link
Member Author

mattab commented Sep 23, 2016

Unfortunately no time to fix this in 3.0.0 - although it will be done in the future for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant