Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching recursively in sub-tables does not always work as expected #10292

Closed
phoob opened this issue Jul 12, 2016 · 4 comments
Closed

Searching recursively in sub-tables does not always work as expected #10292

phoob opened this issue Jul 12, 2016 · 4 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@phoob
Copy link
Contributor

phoob commented Jul 12, 2016

Hello!

I have created a report with subtables, which are loaded by a separate report (not $this->actionToLoadSubTables = $this->action;). I want to be able to search the datatable recursively (by setting $view->config->search_recursive = true; in configureview), but when I do this, and search for something in a subtable, the wrong subtable is loaded when I try to expand it.

I have noticed that other reports (such as those generated by the Events plugin and the Keyword report in the Referrer plugin) do not search recursively. Is this not possible? It would be useful if it was. The steps to reproduce, when using my plugin, are:

  1. Create a record and a report with a datatable with subtables
  2. Open the report and search for something that you know is in a subtable
  3. Observe that only the rows in the main data table that have the relevant subtables are shown
  4. Click on the +-sign to load the subtable
  5. Observe that a different subtable is loaded – not the one that is stored as the subtable for that row

The thing is I am not sure if this is a bug or if I am doing something wrong. Looking forward to any kind of response :)

I would gladly supply some code, but the plugin depends on specific event actions in the database, so I'm afraid that won't do any good.

@mattab
Copy link
Member

mattab commented Jul 13, 2016

Hello @phoob

Good to hear you are experimenting with the Piwik platform!

but when I do this, and search for something in a subtable, the wrong subtable is loaded when I try to expand it.

Does it happen for all dates? if it happens for "today" only, this may be this known issue: #1024 (comment)

@phoob
Copy link
Contributor Author

phoob commented Jul 14, 2016

Thank you for your response, @mattab . It happens for all dates. I actually found a way to reproduce this with a core plugin (Referrers). See the screencast of the test here:

https://youtu.be/9XGXj_HjQc0

@mattab
Copy link
Member

mattab commented Jul 15, 2016

Thanks for the screencast @phoob that's really helpful. The bug might be fixed with: https://github.com/piwik/piwik/pull/10303/files - could you test the patch and confirm?

@mattab mattab added this to the 2.16.2 milestone Jul 15, 2016
@mattab mattab self-assigned this Jul 15, 2016
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jul 15, 2016
@phoob
Copy link
Contributor Author

phoob commented Jul 15, 2016

Awesome, @mattab , it works! This is perfect :)

@mattab mattab changed the title search_recursive Searching recursively in sub-tables does not work as expected Aug 2, 2016
@mattab mattab changed the title Searching recursively in sub-tables does not work as expected Searching recursively in sub-tables does not always work as expected Aug 2, 2016
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

No branches or pull requests

2 participants