Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New install of Piwik 2.16.1 incorrectly reports Tracker Status 500 "GET request to piwik.php failed." #10283

Closed
richb-hanover opened this issue Jul 8, 2016 · 23 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@richb-hanover
Copy link

richb-hanover commented Jul 8, 2016

Installing Piwik 2.16.1 on Ubuntu 14.04.4 LTS. It's my own VPS (with root access). (This is information from https://forum.piwik.org/t/new-install-of-piwik-2-16-1-receive-get-request-to-piwik-php-failed/20115/1)

I am stuck at the System Check page that displays the message above (screen shot below). Here is my installation process:

I then connect to my host in my browser to start the web-based installation. I get to the System Check page and see the 500 Error for Tracker Status with the "GET request to piwik.php failed." message.

I do not have HTTP Authentication or mod_security running on this host (at least, none of the other virtual hosts see these errors.) Further troubleshooting:

  • When I browse to my site http://example.com/piwik.php, I get a 500 Server error
  • The error.log file contains the message below.
  • There is no file named /var/www/piwik/config/config.ini.php (consistent with error.log message below)
  • There is a file named /var/www/piwik/config/global.ini.php.

Any thoughts?

Relevant line from error.log file

[Thu Jul 07 08:57:54.337334 2016] [:error] [pid 28290] [client 64.222.236.200:60707] PHP Fatal error: Uncaught exception 'Exception' with message 'The configuration file {/var/www/piwik/config/config.ini.php} has not been found or could not be read.' in /var/www/piwik/core/Application/Kernel/EnvironmentValidator.php:63\nStack trace:\n#0 /var/www/piwik/core/Application/Kernel/EnvironmentValidator.php(44): Piwik\\Application\\Kernel\\EnvironmentValidator->checkConfigFileExists('/var/www/piwik/...', false)\n#1 /var/www/piwik/core/Application/Environment.php(185): Piwik\\Application\\Kernel\\EnvironmentValidator->validate()\n#2 /var/www/piwik/core/Application/Environment.php(94): Piwik\\Application\\Environment->validateEnvironment()\n#3 /var/www/piwik/piwik.php(56): Piwik\\Application\\Environment->init()\n#4 {main}\n thrown in /var/www/piwik/core/Application/Kernel/EnvironmentValidator.php on line 63

Screen shot of the error message on the System Check page

image

@ZacharyDuBois
Copy link

ZacharyDuBois commented Jul 9, 2016

I am having this issue too.

Ubuntu 14.04
Nginx: nginx/1.10.1
Piwik 2.16.1
PHP-FPM 7.0.8-3+deb.sury.org~trusty+1

Error log

2016/07/09 13:00:45 [error] 5714#5714: *34 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught Exception: The configuration file {/srv/http/telemetry/public/config/config.ini.php} has not been found or could not be read. in /srv/http/telemetry/public/core/Application/Kernel/EnvironmentValidator.php:63
Stack trace:
#0 /srv/http/telemetry/public/core/Application/Kernel/EnvironmentValidator.php(44): Piwik\Application\Kernel\EnvironmentValidator->checkConfigFileExists('/srv/http/telem...', false)
#1 /srv/http/telemetry/public/core/Application/Environment.php(185): Piwik\Application\Kernel\EnvironmentValidator->validate()
#2 /srv/http/telemetry/public/core/Application/Environment.php(94): Piwik\Application\Environment->validateEnvironment()
#3 /srv/http/telemetry/public/piwik.php(56): Piwik\Application\Environment->init()
#4 {main}
  thrown in /srv/http/telemetry/public/core/Application/Kernel/EnvironmentValidator.php on line 63" while reading response header from upstream, client: [redacted], server: telemetry.zacharydubois.moe, request: "GET /piwik.php?url=http://example.com HTTP/1.1", upstream: "fastcgi://unix:/var/run/php/php7.0-fpm.sock:", host: "telemetry.zacharydubois.moe"

@csaeum
Copy link

csaeum commented Jul 9, 2016

the same here
Nginx: nginx/1.10.1
Piwik 2.16.1
Debian 8
PHP-FPM 5.6

@tsteur
Copy link
Member

tsteur commented Jul 10, 2016

Do you actually get that error when you request piwik.php on that server or is it maybe from another request when eg opening the installer the first time? I just downloaded a copy of 2.16.1 and everything works fine for me. Our automated tests work as well. It must be a server related issue. Can you see anything else in the logs?

Looking at the code it must think it is in CLI mode. Can you try to replace the first line here https://github.com/piwik/piwik/blob/2.16.1/core/Common.php#L129 with return false; and give it another try?

@richb-hanover
Copy link
Author

Do you actually get that error when you request piwik.php on that server or is it maybe from another request when eg opening the installer the first time?

Thanks for your response. Yes, If I request http://myserver.com/piwik.php, the web browser inspector shows a 500 error. This happens if I rm -rf the piwik directory and unzip it again.

I just downloaded a copy of 2.16.1 and everything works fine for me. Our automated tests work as well. It must be a server related issue. Can you see anything else in the logs?

The only related messages are identical to the one shown in the original post.

Looking at the code it must think it is in CLI mode. Can you try to replace the first line here https://github.com/piwik/piwik/blob/2.16.1/core/Common.php#L129 with return false; and give it another try?

Replacing line 129 completely (that's the line with if (is_bool(self::$isCliMode)) { ) would give a syntax error. I inserted return false; above line 129 and got a complaint that the file-length check failed, and that perhaps the file was corrupted.

Do you have any explanation for the message that indicates that the config file /var/www/piwik/config/config.ini.php is missing?

@ZacharyDuBois
Copy link

Yes, it does 500 on my setup. It has to be caused by a syntax error somewhere as I just ignored the error and proceeded with the install, piwik.php returns correctly with a 400 "Bad Request" when requesting http://telemetry.domain.tld/piwik.php?url=http://example.com

@tsteur
Copy link
Member

tsteur commented Jul 11, 2016

Replacing line 129 completely (that's the line with if (is_bool(self::$isCliMode)) { ) would give a syntax error. I inserted return false; above line 129 and got a complaint that the file-length check failed, and that perhaps the file was corrupted.

@richb-hanover does it maybe still work when you add it above the line? The error message re file-length check could be ignored in this case. It's just to see where the problem is as we cannot reproduce it. Or maybe someone can give us access to one of the servers that has such a problem?

It is expected that config.ini.php is missing before the installation as it is only created during the installation. There is some logic to ignore this error in piwik.php and it is not supposed to trigger an error when Piwik is not installed yet.

@richb-hanover
Copy link
Author

Thanks for keeping an eye on this.

Could this be a file permission problem? What permissions should be set on the piwik directory/subdirectories? Thanks.

@mattab
Copy link
Member

mattab commented Jul 11, 2016

@richb-hanover just to confirm: have you already installed piwik, your file config.ini.php is created, looks correct, is readable by the web server user, and still you get this message The configuration file {/var/www/piwik/config/config.ini.php} has not been found or could not be read. ?

@richb-hanover
Copy link
Author

I'm not quite sure how to describe the state (I'm not sure if piwik is "installed" or not). I installed piwik using the steps in the initial post above. (unzip, chown, chgrp, then connect with a web browser to begin the web-based install.) Here is the contents of /var/www/piwik/config when I get to the System Check page:

$ ls -al /var/www/piwik/config/
total 736
drwxr-xr-x  3 www-data www-data   4096 Apr 11 16:48 .
drwxr-xr-x 12 www-data www-data   4096 Apr 11 16:48 ..
drwxr-xr-x  2 www-data www-data   4096 Dec 23  2015 environment
-rw-r--r--  1 www-data www-data  39622 Apr 11 16:48 global.ini.php
-rw-r--r--  1 www-data www-data   3102 Nov 18  2015 global.php
-rw-r--r--  1 www-data www-data 695889 Apr 11 16:48 manifest.inc.php

Note that /var/www/piwik/config/config.ini.php is NOT present. Thanks again for your attention.

@mattab
Copy link
Member

mattab commented Jul 13, 2016

Note that /var/www/piwik/config/config.ini.php is NOT present.

When config.ini.php is not present, this means that Piwik is not installed.

If someone is blocked from installing Piwik because of this bug, please let us know here, and ideally we will need FTP or SSH access to your piwik server for us to troubleshoot further (please email via: http://piwik.org/contact ). We'd like to fix this issue 👍

@ZacharyDuBois
Copy link

@mattab The issue does not block the installation. We are saying it is falsely identifying the setup. The page is indeed 500'ing for an uncaught exception that appears to be related to the fact the system is not configured (IE no config.ini.php). As soon as the installation finishes (Ignoring the 500 warning) the /piwik.php returns a standard 400 - bad method which is what it should do. The issue isn't a specific setup, the issue is the installer checks for /piwik.php wrong. Something in /piwik.php depends on the configuration file to exist and the check that just fetches the /piwik.php fails because of that dependency. The check is flawed and is non-configuration specific as I have just confirmed it on the following VMs with 'standard' setups.

  • Ubuntu 14.04 LTS Nginx + PHP7 (FPM) + MariaDB
  • Ubuntu 14.04 LTS Nginx + PHP5 (FPM) + MariaDB
  • Ubuntu 16.04 LTS Nginx + PHP7 (FPM) + MariaDB
  • Ubuntu 16.04 LTS Nginx + PHP5 (FPM) + MariaDB
  • Ubuntu 14.04 LTS Apache + PHP7 (Module) + MariaDB + HT-files enabled
  • Ubuntu 14.04 LTS Apache + PHP5 (Module) + MariaDB + HT-files enabled
  • Ubuntu 16.04 LTS Apache + PHP7 (Module) + MariaDB + HT-files enabled
  • Ubuntu 16.04 LTS Apache + PHP5 (Module) + MariaDB + HT-files enabled

@richb-hanover
Copy link
Author

richb-hanover commented Jul 14, 2016

Yes, ZacharyDuBois describes the situation exactly. I think it's a reporting problem - the "Server Check" page reports the 500 error. Consequently, I stopped and reported the message here.

(One time, I did decide to click Next. I was taken to the MySQL database setup page, but I decided not to proceed with the database until all previous steps complete without error.) Thanks again.

@tsteur
Copy link
Member

tsteur commented Jul 14, 2016

It shouldn't return the 500 error, I think we are either talking about 2 different problems or it's not clear. The tracker, even when it is not installed yet, should report an HTTP 200 AFAIK
image

This is a screenshot of when I am installing Piwik. And it reports tracker status correctly:

image

The tracker is supposed to ignore the config error and return an HTTP 200 if Piwik is not installed yet, meaning if config.ini.php is missing. It is not supposed to return HTTP 500 or 400. So there seems to be a problem somewhere and I was initially thinking it was detecting it maybe wrongly as being executed from CLI https://github.com/piwik/piwik/blob/2.16.1/core/Common.php#L129 where it was not executed from CLI but the web. Looking at the error message again it seems to actually detect it correctly that it was executed from the web. Otherwise the error message would be longer.

It is supposed to ignore the error here: https://github.com/piwik/piwik/blob/2.16.1/core/Application/Kernel/EnvironmentValidator.php#L65-L77 but somehow it is instead throwing the error. It means for some reason it is not detecting that it is running in Tracker mode which means there might be related to $GLOBALS (not "register_globals") but it shouldn't. Can someone in line 40 https://github.com/piwik/piwik/blob/2.16.1/core/SettingsServer.php#L38-L41 replace return !empty($GLOBALS['PIWIK_TRACKER_MODE']); with return true and check if it still reports an error?

@mattab mattab added this to the 2.16.x (LTS) milestone Jul 15, 2016
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Jul 15, 2016
@mattab
Copy link
Member

mattab commented Jul 19, 2016

as we are planning to release 2.16.2 in the next few days, we would need to fix this issue soon for the fix to be in 2.16.2. If anyone is able to help us troubleshoot as per our previous comment here, it would be helpful!

@mattab mattab modified the milestones: 2.16.3, 2.16.x (LTS) Jul 19, 2016
@richb-hanover
Copy link
Author

@tsteur Replacing the line 40 as suggested (with "return true;") generates a different error:

An error occurred
The configuration file {/var/www/piwik/config/config.ini.php} has not been found or could not be read.

What other information could I provide? Thanks.

mattab added a commit that referenced this issue Jul 20, 2016
…s (not) readable

* When the config file exists but is not readable, provide users the choice between making the file readable, or starting a fresh install
* As long as Piwik is not installed, piwik.php should not return 500 when config file is not readable
* Fixes #10283
@mattab mattab modified the milestones: 2.16.2, 2.16.3 Jul 20, 2016
mattab added a commit that referenced this issue Jul 21, 2016
…le still exists but is not readable (#10331)

* * In messages, make it more clear whether config file exists and/or is (not) readable
* When the config file exists but is not readable, provide users the choice between making the file readable, or starting a fresh install
* As long as Piwik is not installed, piwik.php should not return 500 when config file is not readable
* Fixes #10283
* UI tests: updated message when config file is not found
@mattab
Copy link
Member

mattab commented Jul 21, 2016

Hello guys, Somehow the bug appeared on my dev machine, so I investigated it. The issue should be fixed in the latest 2.16.2-beta release 2.16.2-b4. Could you please test it and report whether it is fixed correctly?

@richb-hanover
Copy link
Author

Where would I find the beta download? Thanks.

mattab added a commit that referenced this issue Jul 21, 2016
@mattab
Copy link
Member

mattab commented Jul 21, 2016

Here is the latest beta: http://builds.piwik.org/piwik-2.16.2-b5.zip

you can also easily upgrade to beta using the UI, see: http://piwik.org/faq/how-to-update/faq_159/

please test with at least 2.16.2-beta6

@richb-hanover
Copy link
Author

@mattab I just tried 2.16.5-beta5, and it was almost perfect.

  1. The installation was successful - I am getting statistics on my dashboard.
  2. .../piwik.php now gives the expected 200 status and "Piwik is a free/libre web analytics that lets you keep control of your data." page.
  3. But... I still get the 500 warning for Tracker Status (see image in original post).

TL;DR Piwik install works if you ignore the warning. But it still gives the (somewhat ominous) Tracker Status error in the second installation screen.

@mattab
Copy link
Member

mattab commented Jul 21, 2016

@richb-hanover Thanks for trying. I managed to let a bug slip in beta5 which should be fixed in beta6 - maybe you have a chance to test beta6?

@richb-hanover
Copy link
Author

@mattab Would it be as simple as

  • rm -rf piwik
  • unzip b6
  • chmod/chgrp to www-data
  • re-running the install via the web?

Or would I have to drop tables from the database, etc.?

@mattab
Copy link
Member

mattab commented Jul 21, 2016

@richb-hanover sounds good, you don't have to drop tables

@richb-hanover
Copy link
Author

It worked a treat! Thanks for fixing this.
piwik2 16 2-b6 worked

@mattab mattab changed the title New install of Piwik 2.16.1 - Tracker Status 500 "GET request to piwik.php failed." New install of Piwik 2.16.1 incorrectly reports Tracker Status 500 "GET request to piwik.php failed." Aug 2, 2016
tsteur added a commit that referenced this issue Aug 30, 2016
* Add link to Product changelog in the Developer changelog (#10046)

Here is a recent comment from a community member ` another colleague found and pointed me to your changelog for 2.16.1, which was admittedly hard to find, ` which triggered me to add a clear link in our visible changelog root file.

* Update FrontController documentation (#10049)

* Update link to the overview

* Remove deprecated method from example

* Add TweakStyle browser icon

* Add possibility to execute plugin test suite

* 2.16.2-b1

* Fix pagination in datatables when displaying all entries (#10063)

* fix #4410 The string to escape is not a valid UTF-8 string (#10050)

*  	Trigger a Goal conversion for "Event matching goals" even when an event is tracked without a URL (#10018)

* use idGoal parameter in system tests

* Trigger a Goal conversion for "Event matching goals" even when an event is tracked without a URL

* Test files for green build

* Add new expected test file

* do not start a session during tracker mode or if session is not started yet (#10071)

Eg could start a session during tracking if a tracker plugin is not compatible with the current Piwik and it would try to trigger a notification because of this.

* Implements #9389 - UserId module, that adds a new Users report (#9883)

* Implement the UserId module, that adds a new Users report showing all unique user IDs and some aggregated data. Includes reindexing of raw visitors log into aggregated user ids table

* Update UserId module: add total_actions, total_events and total_searches columns; format dates

* Use an injected model instead of creating a new object

* Rework the UserId plugin to use core archiver instead of custom indexer

* Users report small changes:
- remove logger injection
- change archive record name
- add low population filter
- add all columns visualization
- add datatable_archiving_maximum_rows_userid_users configuration, default value is 50000

* Remove unused method parameter

* Users report: remove custom visualizations and add data-row-metadata attribute for every row

* minor UserId tweaks, enable row evolution for userId etc (#10072)

* addding userId plugin description and enable plugin during update (#10073)

* Fix processed metrics are not shown in visitor map when viewing cities

Eg nb_actions_per_visit
bounce_rate
avg time per visit

Bounce rate seems to always show 100% now but not sure why

* some more fixes

* fix tests after adding new userid feature

* Fix tests

* Ignore idvisitor in system tests as it always changes in each test
* Skip email tests in case intl extension is not installed
* Update ui tests

* update submodules

* Explain a user should call setSessionCookieTimeout when changing visit length

* value should be specified in seconds, not milliseconds

* fix example was wrong

* language update

* allow + in database names during setup (#10091)

* only fail when at least 5 domains extensions are failing, so it does not fail every time IANA adds a new domain extension...

* Remove travis `group: legacy` and use their latest infrastructure (#10094)

* Removed group:legacy from travis.yml template

* use latest php 5.3 instead of php 5.3.3

* Run MySQL off the RAM in our CI server to have fast builds

* Use travis files from latesst master branch commit

* updates travis.yml

* language update

* refs matomo-org/searchengine-and-social-list#3 improves detection for google searches without keyword

* refs matomo-org/searchengine-and-social-list#3 improves detection for yahoo searches without keyword

* Fix some typos in comments (found by codespell) (#10120)

Signed-off-by: Stefan Weil <sw@weilnetz.de>

* refs matomo-org/searchengine-and-social-list#3 improves detection for yahoo japan searches without keyword

* fixes #10130 7 days in Evolution over the period when Period is Day

* misc: Fix typos (found by codespell) (#10136)

Signed-off-by: Stefan Weil <sw@weilnetz.de>

* plugins: Fix typos (found by codespell)

Signed-off-by: Stefan Weil <sw@weilnetz.de>

* submodule update

* language update

* improve referrer type detection for direct entries

ignore fallback detection (same host for referrer and action) if ignore unknown urls is activated for current site

* adds some more test cases

* update translation command to use ProgressBar instead of deprecated ProgressHelper

* Manage Website: Links to website (#10087)

* Manage Website: Links to website

Add clickable urls for each website as requested in #10066.

* Remove extra = and whitespace

Updated style

* New tab, rel noreferrer, ng-href, commas

Changed the urls to open in new tabs, rel=noreferrer, ng-href, and add commas back into the list as requested

* Fix pasting error

Edit out extra </a> and {{ urls}}

* Change div to span

Change div to span to have url on the correct line

* When only a icon is rendered, the title is not enough to provide an accessibility label, so it an aria-label to the icon so screen reader element lists and such have something to display.

* Update urlnormalizer.js (#10171)

* Update piwik.js (#10170)

* JavaScript SDK: add support to send tracking requests to multiple Piwik servers and/or store in one or  multiple websites ID (#10085)

* Add support to configure multiple trackers easily

* added tests

* fix tests

* 2.16.2-b2

* Use Common::sendHeader for consistency

* Up to date minified piwik.js #10085

* Screenshot UI tests pixel alignment minor change

* Escape the value as suggested in the Pr comments.

* language update

* refs plugin-CustomDimensions#31 fix doc block for custom dimension was wrong

* add callback ability to trackPageView (#10172)

* Update piwik.js

* Update piwik.js

* submodule updates

* language update

* update languages

* rebuilt piwik.js

* split all tests (#10192)

* submodule update

* fix some tests

* device detector update

* Add mention to BrowserStack.com in our readme (#10205)

* Check if UserCountry plugin is activated before showing location data

* ensure to reset translated categories for each system test (#10210)

* link to useful CI build result dashboard and tweaks

* in Evolution over the period when Period is Day the limit should be actually 8 instead of 7

See #10130 (comment)

* Fix the flags of Switzerland and Nepal

Adding a transparent padding ensures the flags will not be stretched to
the 16x11 format of all the other flags.

* Update the flag of Tokelau

* Update the flag of Myanmar

* Update the flag of Lesotho

* Update the flag of Libya

* Update the flag of French Guiana

* fixed some typos [ci skip]

* fix report order of browser reports

* update tests with new order

* Update JQuery to the latest 1.12.4 version (#10260)

* Update JQuery to the latest 1.* version

* UI tests: Updated Jquery to latest version

* submodule update

* Update jquery to latest 1.*, new release checklist test

* language update

* Remove uneeded HTML files from a JS library

* Put idSite into single quote for support custom string id (#10247)

* Put idSite into single quote for support custom id

This is small change, but is necessary for #9975 and #4920. On my tests, even with single quote, numeric idSite works fine.

* Change unit test expected to support test with strings

* Change expected data to support test with strings

* submodule update

* submodule update

* Tweak core:archive output logging to better explain where to find error log depending on server configuration

* Adding hyphen for consistency

* Composer: remove the disable tls flag, refs #10023 (#10277)

* Do not throw an exception when debugging tracker (#10267)

This method is only called when Tracker debugging is enabled. It may cause problems if an unknown type is used and then the tracking completely fails which also stops tracking. Debugging info should not really throw exceptions, at least not in this case.

* Fix CSV export cannot be used with dates like previousX (#10273)

* fixes #9838 - show description bubbles below column if they would be out of viewport if shown above

* submodule update

* Let plugins provide custom piwik.js tracker tests (#10270)

Plugins could provide custom tracker tests by creating a file 'tests/javascript/index.php' within the plugin.

Won't be a documented feature for now but could add it to dev changelog if needed.

Content within the test file could be eg 
```
<script type="text/javascript">
test("MyPiwikTest", function() {
    expect(1);

    var tracker = Piwik.getTracker();

    equal(typeof tracker.trackGoal, 'function', 'trackGoal' );
});
</script>
```

* Fix segment data disappears from UI after changing auto_archive setting  (#10078)

* refs #10036 fallback to global done flag if plugin done flag has no archive/data

* global done flag might be the same as the plugin done flag if no segment and no range is used

* installing touch-punch lib to fix dragging issue on mobiles (#10045)

*  Reset the list of items in the cart, after tracking an ecommerce conversion (#10279)

* Clarify that token_auth must be  an admin or super user token.

* Reset the list of items in the cart, after tracking an ecommerce conversion

But do not reset the list of itms in the cart after tracking an ecommerce cart update.
fixes #10252

* Adding changelog note
`piwik.js`: after an ecommerce order is tracked using `trackEcommerceOrder`, the items in the cart will now be removed from the JavaScript object. Calling `trackEcommerceCartUpdate` will not remove the items in the cart.

* Add possibility to specify a custom row aggregation operation (#10288)

* Add possibility to specify a custom row aggregation operation

* added test for row metadata aggregations

* When JSLint validation failed, explain where to find the error messages refs #10271 (comment)

* trackLink does not invoke callback if request is done via GET (#10294)

* trackLink does not invoke callback if request is done via GET

* Update piwik.js

* Make JSlint errors output actually useful to developers

* JSLint: better error reporting, correct line numbers #7232

* Improved join generation for segments (#10264)

* better join generation for segments
* do not update visit if there are no values to be updated

* Calling an undefined JS API method should not trigger an error in the console (#10176)

* When calling a non existing method, do not fail JS execution but print a useful error message in browser console

* Fix

* Throw an error so developers can see in the browser console

* Up to date minified piwik.js

* Improve detection for empty keywords by allowing to define that in search engine definitions

* updates piwik/searchengine-and-social-list dependency

* refs #9984 - adds confirmation when changing segments definition

* refs #9984 - adjust UI test to automatically confirm confirmation

* better naming

* record actual screen resolution when using JS tracker (#10296)

* Add current domain to list of domains automatically only if no path is set (#10051)

* Do not add current domain automatically if setDomains is called, might also fix a bug in IE11

* this might fix jslint test

* added tests and fixed a bug

* fix tests

* Up to date piwik.js

* Minor changes

* Document new internal piwik.js change https://github.com/piwik/piwik/pull/10051/files

* Add link to multiple tracker docs in changelog. #10174

* make sure we prefer forwarded proto header over regular header (#10081)

* 2.16.2-b3

* Fixes #10117

* Fix typo

* Refs #10115

* use better message depending of the availability of archiving triggered by browser

* add option to hide segment definition change confirm

* Add a test for isInsideAnIFrame method in piwik.js  (#10300)

 #10271 #10105

* Searching recursively in sub-tables should work as expected (#10303)

* When a datatable is manipulated in memory, the correct id subtable is stored in metadata and must be fetched from there.

* piwik.js: Prepend a slash to all paths such as when users don't specify leading slash for URL path (#10302)

* Load the JS file in the test where it is used, to prevent errors running tests on IE8
jslint not working on IE8 it seems

* Fix JS error when running tests in edge browser

* iframe waits for document ready

* Fix the JS tests on Chrome

* Fix issue IE

* Fix for IE9: wait for window.onload

* Fixes #10105 - copied from #10271 by @Kijewski (#10306)

* submodule updates

* Added API method to get a single goal (#10305)

* added method to get a goal

* always fetch goal directly to not having to iterate over all goals

* added new changelog entry for devs

* updates phpunit dependency / submodule updates

* submodule updates

* Use log tables to decide which tables can be purged (#10304)

* use log tables to decide which tables can be purged

* make sure to return the number of deleted visits

* fix tests

* UI tests: Log tables purge

* added app manifest (#10321)

* Fixes #10276

* Update piwik/network component to 0.2.0 release for IPv6 ranges support #9411 (#10324)

* language update

* Segment editor, updating segments, logic when to display messages  (#10322)

* Display the right message when segment is set to real time

* Correct logic

* UI tests: minor messaging change

* Submodules including matomo-org/travis-scripts#28 #10323

* Update integration tests for #10276

* Remove comment

* submodule update

* submodule updates

* Php7 compatibility, Pear archive_tar package #10058

* Update submodules

* fixes #10310 - use indexOf polyfill function to avoid errors in older IEs (#10327)

* pass instance of both row objects to aggregate callback when aggregating them (#10330)

* Update composer libraries, while enforcing the minimum php in composer.json  (#10334)

* Enforce the Minimum PHP version in composer.json using "platform" feature
Added in composer/composer@a57c51e

It was found that this flag is very important to use to make sure the package we build and release will be compatible with this PHP version.
Otherwise, the minimum PHP version enforced would be the version where our build script runs, which could be PHP 5.5 or PHP 7 which would have caused serious issues.

* Update doctrine/cache, monolog,piwik/network, piwik/cache, piwik/php-tracker  etc.
#10058

* Release checklist to check that composer.json is correctly defined

* Use latest travis scripts for matomo-org/travis-scripts@30d7b16

* .travis.yml file is out of date, auto-updating .travis.yml file.

* Use latest travis scripts for matomo-org/travis-scripts@63445cf

* .travis.yml file is out of date, auto-updating .travis.yml file.

* Fetch latest referrer spam blacklist refs  #10058

* When Piwik config file becomes un-readable, make it clear that the file still exists but is not readable (#10331)

* * In messages, make it more clear whether config file exists and/or is (not) readable
* When the config file exists but is not readable, provide users the choice between making the file readable, or starting a fresh install
* As long as Piwik is not installed, piwik.php should not return 500 when config file is not readable
* Fixes #10283
* UI tests: updated message when config file is not found

* Update submodules to latest - refs #10058 (#10335)

* 2.16.2-b4

* Refs #10331 #10283

* 2.16.2-b5

* Add require_once to prevent build failure

* Add missing file

* 2.16.2-b6

* Professional Services for Piwik, neutral branding within Piwik app (#10339)

Professional Services for Piwik - neutral branding within Piwik app

* 2.16.2-rc1

* Update submodule, and fix to update file

* 2.16.2-rc2

* UI tests: fixed typo

* language update

* add possibility to create ui tests for users with view access only

* Added Recommended Drivers During Installation (#10346)

* Fixed

* Made Recommended Changes

* Add support section to plugin json template (#10358)

* Add support section to plugin json template

As suggested by a developer. The Marketplace has been supporting this for quite a while already.

* Added support section to example theme plugin json

* added wiki section

* added wiki section

* Adding couple issues to the changelog  #10058

* Do not document until finalised #10270

* Update to Device detector 3.7.1 (#10362)

* Device detector 3.7.1

* Fix build

* 2.16.2 KABOOM

* fix #10361 (#10361)

Now only the english string is changed, as translations are handled via https://www.transifex.com/piwik/piwik/

* Add pull request template mentioning PRs should be made against 3.x-dev (#10030)

* Do not limit password length (#10349)

* Disabled Max Password Length Check

* Disabled Max Password Length Check

* Reset config files

* Translation & other fix

* Fixed Test Case for Very Long Passwords

* UI tests:  #10357

* fixes #10374 generate:visualizationplugin was not working

* support section is no longer needed

* language update

* Update global.ini.php (#10408)

* submodule updates

* Remove again the Hiring file  #9814

* Minor Improvement to description

* Fix the integration test and patch Zend Validate

* on Travis use PHPUnit from composer

* Create index.htm files in all tmp/ sub-folder as an additional safety net (#10414)

* Create index.htm files in tmp/ folder as safe net

*  UI test

* silent fail

* fix unit test

* Minor Improvement to description

* Fix release checklist

* Fix release checklist

* UI test

* UI test logic

* Actually make methods public to keep BC

* Fix fatal error when requesting RSS format  (#10407)

* Fixes #10399

* add test reproducing issue #10399

* another health check

* Fix no required Piwik version was defined (#10413)

* Fix no required Piwik version was defined

* plugins should specify an upper version constraint to the next major version

* PHP 7: when there is a fatal error in API request processing, display the original error in the api response (#10406)

* PHP 7: when there is a fatal error in API request processing, display  the original error

* PHP 7 compatibility

* Use Piwik 40.0.0 so that test does not need to be updated soon

* UI test

* UI tests: plugins not compatible with next version are shown

* language update

* submodule update

* Split piwik.js into multiple files and provide a merged one (#10441)

refs #6106

* Fixes #10143 (#10424)

* Fix issue when running archiving via the old archive.php path
Notice: Use of undefined constant PIWIK_DOCUMENT_ROOT - assumed 'PIWIK_DOCUMENT_ROOT' in plugins/CustomPiwikJs/Commands/UpdateTracker.php

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

5 participants