@Kijewski opened this Pull Request on July 4th 2016

Accessing window.frameElement throws an Error in IE if the iframe has
another origin than its parent. If there is an error on accessing
window.frameElement, then we know that we are inside an iframe.

Closes #10105.

@mattab commented on July 8th 2016 Member

Looks good to me @Kijewski ! The only thing I found is that the JSLint now fails and I'm not sure why...

@Kijewski commented on July 8th 2016

@mattab, probably I have to declare the variable at the top of the function. The rest of the code does. Let's see what Travis says.

@Kijewski commented on July 9th 2016

OK, that was one error. The first lint printed

JSLINT errors [object Object],[object Object]

now it's

JSLINT errors [object Object]

but I don't know what the other error is. :-/

@tsteur commented on July 10th 2016 Member

When you run the tests and open the developer tools in the browser (when you execute tests via http://piwikDomain/tests/javascript) it should log the exact error to the console

@Kijewski commented on July 13th 2016

@tsteur, @mattab, thank you!

May I squash my commits now, or should I wait a review first?

@tsteur commented on July 13th 2016 Member

Feel free to squash already. We will need to test it then in various browsers

@mattab commented on July 14th 2016 Member

fyi: wrote a test for the isInsideIframe function, maybe will be useful for crossbrowser testing https://github.com/piwik/piwik/pull/10300

@mattab commented on July 15th 2016 Member

Thank you for the PR @Kijewski - re-created it here: #10306

This Pull Request was closed on July 15th 2016
Powered by GitHub Issue Mirror