Changed warning message about invalid plugins to be more helpful #10251
Conversation
| @@ -19,7 +19,8 @@ | |||
| "ImageTrackingLink": "Image Tracking Link", | |||
| "ImportingServerLogs": "Importing Server Logs", | |||
| "ImportingServerLogsDesc": "An alternative to tracking visitors through the browser (either via JavaScript or an image link) is to continuously import server logs. Learn more about %1$sServer Log File Analytics%2$s.", | |||
| "InvalidPluginsWarning": "The following plugins are not compatible with %1$s and could not be loaded: %2$s.", | |||
| "InvalidPluginsWarning": "The following plugins could not be loaded: %1$s.", | |||
| "InvalidPluginsWarningReasons": "Possible reasons of this situation are: plugin is not compatible with %1$s, plugin's directory is not readable or is empty.", | |||
There was a problem hiding this comment.
Maybe rather something like
Please check if the plugin's directory exists and is readable. If so, the plugin may not be compatible with %1$s.
Problem is people won't know how to check whether a plugin is compatible. It would be even better to check all these things and then directly point it out. Eg we could check whether a plugin is not compatible, we could check if directory does not exist and mention it, and we could check if directory exists but is empty (or misses a plugin.json)
👍 to write the actual cause of the error, so it is most helpful for troubleshooting without effort needed on the user's part. |
|
@mattab This is a good idea and it is even worth to enhance it: set of plugin validators can be created that would be reusable in many places in Piwik, for example also in plugin:activate command, where information about problems with plugin would be very helpful. But so far we have no resources to implement feature where for each plugin actual cause of problem is displayed. Change introduced with this PR is still some improvement which may significantly decrease time spent on investigating why plugin cannot be activated. |
mattab
added
the
Pull Request WIP
|
@adaqus Sounds like maybe you would not apply the feedback to the PR. I'm closing for now but feel free to re-open with the feedback applied and we'll be happy to merge 👍 |
Currently when plugin cannot be loaded warning message looks as below:
This information is misleading, because it appears also when plugin's directory is empty or is not readable. This PR introduces following message: