Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when --force-idsegments is specified, Piwik will archive "all visits" for the day period before archiving the segment(s), but is it necessary? #10234

Closed
quba opened this issue Jun 15, 2016 · 3 comments
Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@quba
Copy link
Contributor

quba commented Jun 15, 2016

When specifying the --force-idsegments parameter, Piwik archives the day period for "all visits" and then for the specified list of segments. When archiving the week (and others) period, Piwik skips standard "all visits" archiving and archives only the specified list of segments.

It's not needed to perform the standard archiving while forcing segments to be archived.

In addition, it also seems to not work fully with the --concurrent-requests-per-website. For the day period, it starts with "all visits" and then proceeds with segments. For other periods, it starts immediately with "all visits" and first X segments.

@tsteur
Copy link
Member

tsteur commented Jun 17, 2016

I think the first one is a feature request to not archive the regular one when force-idsegments is given while the concurrent-requests-per-website sound more like a bug.

@tsteur tsteur added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Jun 17, 2016
@mattab
Copy link
Member

mattab commented Jul 8, 2016

It's not needed to perform the standard archiving while forcing segments to be archived.

I think it's needed at the moment to process the archive without segment, so that Piwik knows that there is data for the day and actually trigger the archiving. If there is no data for the day for 'all visits' then Piwik knows there is no data for segment neither, which improves performance significantly when it was implemented.

In addition, it also seems to not work fully with the --concurrent-requests-per-website.

different issue, please let's keep one issue per ticket 👍

@quba
Copy link
Contributor Author

quba commented Jul 8, 2016

#10281 created.

I think it's needed at the moment to process the archive without segment, so that Piwik knows that there is data for the day and actually trigger the archiving. If there is no data for the day for 'all visits' then Piwik knows there is no data for segment neither, which improves performance significantly when it was implemented.

Such check should be done for both "all visits" and segmented data. Then daily archiving for "all visits" could be skipped when forcing a specific segment. This would also speed up archiving when a heavy segment which returns no data is defined.

@mattab mattab changed the title --force-idsegments archiving parameter works incorrectly with the day period when --force-idsegments is specified, Piwik will archive "all visits" for the day period before archiving the segment(s), but is it necessary? Jul 15, 2016
@mattab mattab added the c: Performance For when we could improve the performance / speed of Matomo. label Jul 15, 2016
@mattab mattab added this to the 2.16.x (LTS) milestone Jul 15, 2016
@mattab mattab modified the milestones: 2.16.x (LTS), Mid term Aug 25, 2016
@mattab mattab closed this as completed Aug 17, 2019
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants