Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies in how conversions / actions / visits are attributed to a certain day #10224

Closed
tsteur opened this issue Jun 9, 2016 · 4 comments
Closed

Inconsistencies in how conversions / actions / visits are attributed to a certain day #10224

tsteur opened this issue Jun 9, 2016 · 4 comments
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@tsteur
Copy link
Member

tsteur commented Jun 9, 2016

When we generate reports for visits, we aggregate data based on the log_visit.visit_last_action_time see https://github.com/piwik/piwik/blob/2.16.1/core/DataAccess/LogAggregator.php#L315 . This means all visits date ended on that day, are counted towards that day. It doesn't matter if the visit started on the previous day.

On the other side eg for conversions we aggregate based on log_conversion.server_time see https://github.com/piwik/piwik/blob/2.16.1/core/DataAccess/LogAggregator.php#L793. The problem is eg if a conversion happens towards the end of the day, and the visitor stays active for a while, the visit_last_action_time is actually of the next day. This means we might count the visit for the next day, but the conversion for the previous day.

Similar for action reports where we include all actions based on the log_action.server_time field see https://github.com/piwik/piwik/blob/2.16.1/core/DataAccess/LogAggregator.php#L671 . That means some actions might be counted for the previous day whereas some actions could be counted for the next day.

In theory this could result to eg a day with no visits, but conversions and actions. The next day only has visits but no conversions.

A solution could be to always join with log_visit and to always consider log_visit.visit_last_action_time but this could cause performance problems maybe.

@mattab can you confirm this?
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed Bug For errors / faults / flaws / inconsistencies etc. labels Jun 9, 2016
@mattab
Copy link
Member

mattab commented Jul 7, 2016

@tsteur that's a good description. I think it makes sense to count the conversion on the day that it occured, because users care more to track conversions on the correct day, rather than track the conversion in the correct visit.

Maybe we could document this "limitation" in a FAQ, but I wouldn't change the implementation. thoughts?

@tsteur
Copy link
Member Author

tsteur commented Jul 8, 2016

No thoughts, only wanted to clarify it. FAQ sounds maybe good, or at least we have it in an issue here

@tsteur
Copy link
Member Author

tsteur commented Jul 8, 2016

We could close the issue and link to this issue if a user has a question on this or something

@mattab
Copy link
Member

mattab commented Jul 8, 2016

We could close the issue and link to this issue if a user has a question on this or something

👍

@mattab mattab closed this as completed Jul 8, 2016
@mattab mattab added the wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it. label Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsteur @mattab