Removed PSR-0 statement #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Piwik does NOT follow PSR-0, composer makes unnecessary file system calls for every single class. Piwik's own autoloader knows how to load Piwik's classes.
|
Can you please point out where Piwik does not comply with PSR-0? The main goal right now is to be compatible to PSR-0 rather than removing the statement. |
|
According to PSR-0, namespace is translated to directory structure by changing backslashes to directory separators. When composer is trying to load a class, lets take \Piwik\Plugins\Actions\API for example, it checks if a file plugins/Piwik/Plugins/Actions/API.php exists. Since it does not, PHP asks Piwik's autoloader (which is second in the autoloader stack) if it can find the class. |
|
I already commented in http://dev.piwik.org/trac/ticket/4074#comment:2 about moving the directories to comply with PSR-0. |
mattab
pushed a commit
that referenced
this pull request
Aug 26, 2013
Removed PSR-0 statement since it's not valid at this stage (see dicussion in http://dev.piwik.org/trac/ticket/4074#comment:2 for next steps)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Piwik does NOT follow PSR-0, composer makes unnecessary file system calls for every single class. Piwik's own autoloader knows how to load Piwik's classes.