JS Tracker: Configtrackerpause should not be set to 0 if a callback is used. #10179
Labels
Bug
For errors / faults / flaws / inconsistencies etc.
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Help wanted
Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
See #10172 (comment)
In https://github.com/piwik/piwik/blob/2.16.1/js/piwik.js#L4590 we should replace the 2nd parameter
(callback ? 0 : configTrackerPause)
with onlyconfigTrackerPause
. Otherwise we might not wait for an outlink to be fully recorded when a user goes to another page.This condition was added that time in case someone passes the following callback in which this behaviour
(callback ? 0 : configTrackerPause)
made sense in #5850:However, the callbacks may be used for other reasons than setting an url and in all other cases it is buggy to set
configTrackerPause
to 0. The correct way is to calltracker.setLinkTrackingTimer(0)
in such a case where one uses the callbacks for this reason.The text was updated successfully, but these errors were encountered: