Accessility: set a title attribute on Main menu item for better experience on screen readers #10160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccessibility label, so it an aria-label to the icon so screen reader element lists and such have something to display.
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| {% macro menuItemLabel(label, icon) %} | |||
| {% if icon is defined and icon and icon starts with 'icon-' %} | |||
| <span class="{{ icon|striptags }}"></span> | |||
| <span class="{{ icon|striptags }}" aria-label="{{ label|translate }}"></span> | |||
There was a problem hiding this comment.
Do you mind changing it to {{ label|translate|e('html_attr) }} for better escaping? Cheers
mattab
added
the
c: Accessibility
mattab
changed the title
|
Thanks @tyrylu for the pull request, and improving accessibility in Piwik 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixesan accessibility issue in the main menu with items having only an icon. The title attribute is not enough to provide full accessibility, for example NVDA does not show it when navigating using arrow keys or in the elements list. So this change adds an aria-label to the icon when it exists ant therefore the label is not displayed as the link's child.