New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding method of unifying current url and alias #10146
adding method of unifying current url and alias #10146
Conversation
…'t start) with '/'
Can you build a simple html page with a link and the tracking code to reproduce this issue? Otherwise we can't test it and check for regressions. Also let us know about operating system and exact browser version. We did some tests with IE11 recently and it worked fine but it's possible that it only occurs in a certain case. |
Hi @tsteur I'm cooperating with @mgonera, we have a test site (but it's simple - very simple or even Very simple one may say). Don't want to post the links here, because he was the one to setup it, it's on his server. He will probably share it without a problems but I don't want to do this for him. @mgonera, would you be so kind? |
@wronan share whatever is needed, I think they already are here somewhere. Just pass the credentials privately and please indicate the directories on the server (as you may remember I gave you access one level higher than I was supposed to). thanks. |
A simple HTML page could be enough eg with a "paste" service. We don't need a URL |
@tsteur I provided this to your e-mail directly |
@tsteur can you review it? |
My time is a bit limited these days but I can already tell that tests are missing. From the looks it seems like a valid patch but it'll take some time to test it etc. When there are tests then it'll be easier to later to review |
Review
|
Thx man. Sorry for the delay with tests. I'm overwhelmed with work... Till the next PR then :) |
adding method of unifying current url and alias so both start (or don't start) with '/'
Original ticket: #9872