Piwik.js: Explain a user should call setSessionCookieTimeout when changing visit length #10082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ; after his last page view, it will be recorded as a new visit | ||
| ; after his last page view, it will be recorded as a new visit. In case you are using the Piwik JavaScript tracker to | ||
| ; calculate the visit count correctly, make sure to call the method "setSessionCookieTimeout" eg | ||
| ; `_paq.push(['setSessionCookieTimeout', timeoutInSeconds=1800000])` |
There was a problem hiding this comment.
should it be maybe 1800 instead?
There was a problem hiding this comment.
I copy / pasted example from piwik.js where it says Set session cookie timeout (in seconds). Defaults to 30 minutes (timeout=1800000) and 1800000 is actually the default value. Should be probably 1800 as it is multiplied by 1000 in the method.
|
adjusted it, also in piwik.js |
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise piwik.js increases visit count only after 30min