Process goal conversions for device data (type, brand, model) #10070
Conversation
sgiehl
added
not-in-changelog
| $metrics->enrichMetricsWithConversions(); | ||
| } | ||
|
|
||
| $report = $metrics->asDataTable()->getSerialized($this->maximumRows, null, Metrics::INDEX_NB_VISITS); |
There was a problem hiding this comment.
I recommend to call here $table = $metrics->asDataTable(); ... serialize ...; Common::destroy($table); to reduce memory usage
|
Only needs a small change for the possible memory leaks. Otherwise feel free to merge after this change was made 👍 |
sgiehl
force-pushed
the
devicegoalreports-3
branch
from
346d802
to
9535b78
Compare
|
I've updated and rebased the branch. If the tests succeed, I'll merge it afterwards. |
sgiehl
force-pushed
the
devicegoalreports-3
branch
from
9535b78
to
0570243
Compare
sgiehl
force-pushed
the
devicegoalreports-3
branch
from
0570243
to
b53f0ae
Compare
sgiehl
force-pushed
the
devicegoalreports-3
branch
from
b53f0ae
to
3295f87
Compare
|
@sgiehl there is now data on demo2 👍 Just noticed an issue: on demo2 at: https://demo2.piwik.org/index.php?module=CoreHome&action=index&idSite=1&period=month&date=today#?idSite=1&period=month&date=today&category=Goals_Goals&subcategory=1 report shows conversion rates for
|
|
Maybe that's a more general problem. Some keywords have more than 100%, as well.
Had a look at the goal, but it seems it should only be triggered once a visit. |
rebased #10026 for 3.x
(refs #9777)