Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segment filter: no results for "browser": IE AND "Browser version": 11 #10067

Closed
hpvd opened this issue Apr 18, 2016 · 15 comments
Closed

segment filter: no results for "browser": IE AND "Browser version": 11 #10067

hpvd opened this issue Apr 18, 2016 · 15 comments
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.

Comments

@hpvd
Copy link

hpvd commented Apr 18, 2016

There are no results found/shown with segmentation:
"browser": IE
AND
"Browser version": 11

Even if there are hundrets visits visible without v11 filter...
same problem with other browser version numbers..

piwik 2.16.1

@hpvd hpvd changed the title no results with segmentation: "browser": IE AND "Browser version": 11 segment filter: no results for "browser": IE AND "Browser version": 11 Apr 18, 2016
@tsteur
Copy link
Member

tsteur commented Apr 18, 2016

I can reproduce this on our second demo. @sgiehl do you maybe have an idea?

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Apr 18, 2016
@hpvd
Copy link
Author

hpvd commented Apr 19, 2016

good to here.
As already mentioned here #5372 (comment)
filtering by browser version is really important...
(especially at least this basic version)

@hpvd
Copy link
Author

hpvd commented Apr 19, 2016

same in 2.16.2B1

@sgiehl
Copy link
Member

sgiehl commented Apr 19, 2016

Filtering by browser + version does work. The problem is choosing an equals comparison does not work as expected at that point. The browser version is stored like 11.0, 32.345.545.444 or similar. Which means an 11 won't match with 11.0. So you would need to compare with the exact version, or try something like starts with 11. or lower than 12 and at least 11.

@hpvd
Copy link
Author

hpvd commented Apr 19, 2016

@sgiehl Thanks for your details on this!

Well that's not easy no know...

  1. When setting the mouse to the version number field there is a list of proposals with numbers without digits so one could easily choose a number it doesn't work with (please see attachment 1)

  2. there is no format advice shown (please see attachment 2)

  3. uuuh how to select "lower than" and "at least"??? Would like that very much but thought it's not solved yet and part of Numeric value segments: new "Less than" and "more than" conditions  #5372 !?
    (please see attachment 3)

2016-04-19_20h40_34

2016-04-19_20h49_33

2016-04-19_20h47_54

@hpvd
Copy link
Author

hpvd commented Apr 19, 2016

just imho:
"11" should filter all 11.xx versions and "11.1" should filter all 11.1x
if it's working in an other way, there is a hint needed how it's working.
And of course list of proposed values should only contain possible values / or should simply not be shown...

=> what do you think?

@tsteur
Copy link
Member

tsteur commented Apr 19, 2016

That's definitely not intuitive. I did not know it either. Maybe it would be good to have a combo like "IE 11" similar to the report and then it gets split into 2 segments? It's likely not trivial to implement though. I wonder if we could show the segment $acceptValues help text at least as a title when hovering segment name, segment comparison and segment value. Any other ideas?

@sgiehl
Copy link
Member

sgiehl commented Apr 25, 2016

We should definitely find a smarter solution for that. But imho, that is more a usability improvement as a "bug", as Piwik strictly applies the segment as defined.

We could indeed allow some kind of combined segment. But that wouldn't solve the comparison problem. Theoretically the browser version could contain anything. For most cases that will be a version number but it might be a text in some cases. aswell.
As long as Piwik will keep tracking minor versions (e.g. X.Y) only and no patch versions (e.g. X.Y.Z) the comparison might be easy to solve, as we can compare the versions as numbers.

But I'm still unsure how we should compare the versions. Should a 11really match a 11.133, aswell? That would make it impossible to match exactly 11 and no others.

Btw. the list of possible versions shown is correct, but it shows all tracked versions tracked for any browser. So the 11 might match for another browser than IE. Switching to a combined segment would maybe allow to show only available browser/version combinations.

@sgiehl sgiehl added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. and removed Bug For errors / faults / flaws / inconsistencies etc. labels Apr 25, 2016
@tsteur
Copy link
Member

tsteur commented Apr 25, 2016

I guess we likely need two segments like "Browser exact version" and "Browser major version". Maybe we could on top offer at some point a segment like "IE 11.*".

Otherwise in the autocomplete we could maybe show "11", "11.133" but also "11." and when "." is selected we convert it to basically "11.% or 11" and match all versions. However, I reckon ".*" might be only understood by more technical people. I presume having two different segments could be useful.

@hpvd
Copy link
Author

hpvd commented Apr 26, 2016

To find versions and its' sub version more easily, maybe one can also think of a solution where there is only an additional check mark:
"not exact" / "globalize" or similar, which allows to find all subversions:

  • "11" => 11.x.x.x.x
  • "11.1" => 11.1.x.x.x
  • ...
    if check mark is not set it works like it's actually working
    11 => 11.0.0.0.

2016-04-26_07h01_28

regarding suggestions, this could be helpful also in general (not only for browsers)
one could think of always applying the combined conditions setup before the the suggest appears:
Suggest for browser AND Browser Version => suggest for browser version shows only the ones fitting to selected browser before
only check:
the other way around:
AND Browser Version AND Suggest for browser :
Suggestion for browser version should show all versions ever tracked
Suggestion for browser should only show the browsers having the browser version selected before...

what do you think?

@hpvd
Copy link
Author

hpvd commented Apr 26, 2016

the "not exact" function #10067 (comment) would also make sense for other segment filters like e.g.

  • operating system version
  • latitude
  • longitude
  • ...

@hpvd
Copy link
Author

hpvd commented Apr 26, 2016

just another aproach:
couldn't we simply adopt the existing "starts with" condition also for numbers?

@hpvd
Copy link
Author

hpvd commented Apr 26, 2016

when choosing this way, one could alsomake it possibleto find combined data like browser versions of type:
"43.4 beta"
when filtering "browser version" "starting with" "43"

@hpvd
Copy link
Author

hpvd commented Apr 26, 2016

hmmm...adopting "starting with" does not work perfect, because than one can't choose "greater than", "less than" anymore (see #5372 and #8527)

the solution with a checkmark for "not exact" #10067 (comment) should work any way....

@mattab mattab added this to the Mid term milestone Jul 14, 2016
@mattab
Copy link
Member

mattab commented Dec 12, 2023

Thanks for contributing to this issue. As it has been a few months since the last activity and we believe this is likely not an issue anymore, we will now close this. If that's not the case, please do feel free to either reopen this issue or open a new one. We will gladly take a look again!

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Development

No branches or pull requests

4 participants