Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlimited paging in lists when selecting all #10044

Closed
dczajkacc opened this issue Apr 12, 2016 · 1 comment
Closed

Unlimited paging in lists when selecting all #10044

dczajkacc opened this issue Apr 12, 2016 · 1 comment
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone
2.16.2

Comments

@dczajkacc
Copy link

Steps to reproduce:

  1. Find a widget with pagination, e.g. custom vars report - http://demo.piwik.org/index.php?module=CoreHome&action=index&idSite=7&period=day&date=yesterday#?module=CustomVariables&action=menuGetCustomVariables&idSite=7&period=day&date=yesterday
  2. select "all" from dropdown where you can select how many items you want to see
  3. click next few times

result: you can navigate through unlimited number of pages
screen shot 2016-04-12 at 11 40 28

see "-4 -- 6 of 1"
@tsteur
Copy link
Member

tsteur commented Apr 13, 2016

We could maybe set $viewConfig->show_pagination_control = false when filter_limit=-1 but that wouldn't be 100% safe I presume. There might be visualization / API methods that don't use filter_limit.

@tsteur tsteur added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Bug For errors / faults / flaws / inconsistencies etc. labels Apr 13, 2016
@mattab mattab added this to the 2.16.2 milestone Apr 14, 2016
@sgiehl sgiehl self-assigned this Apr 15, 2016
@sgiehl sgiehl mentioned this issue Apr 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
2.16.2
Development

No branches or pull requests
4 participants
@tsteur @mattab @sgiehl @dczajkacc