Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CronArchive module: refactor, add tests, clean code #10032

Closed
mattab opened this issue Apr 11, 2016 · 3 comments
Closed

CronArchive module: refactor, add tests, clean code #10032

mattab opened this issue Apr 11, 2016 · 3 comments
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@mattab
Copy link
Member

mattab commented Apr 11, 2016

Our CronArchive module is a key component of Piwik platform. The goal of this issue is to improve the codebase of the CronArchive, especially:

  • Refactor the class into smaller classes, for readability and maintainability.
  • Write tests for most parts, since most parts are critical.
  • At the end it should be easy to understand and well tested.

(there are several interesting CronArchive open issues: #10031 #9753 #8261 #7856 #6754 #6055 #9849 #9113 #315)

issue created from a major undiscovered-for-four-years bug found in the module: #9468

@mattab mattab added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Apr 11, 2016
@mattab mattab added this to the 3.0.0 milestone Apr 11, 2016
@gausam
Copy link
Contributor

gausam commented Apr 11, 2016

Interesting. Last week I spent a good 3+ hours going over the source passively for CronArchive looking at places I could clean up and tests to write, opened Sublime and it's the file I left open. Happy to join whoever's going to take this on (if anyone is) since I'm now quite familiar with the source.

@mattab mattab assigned mattab and unassigned mattab Apr 21, 2016
@mattab
Copy link
Member Author

mattab commented Dec 10, 2023

Thanks for creating this issue! We appreciate your input. This issue covers a lot of ground, and it's a bit too broad for us to tackle effectively as is. So, we're going to close it for now.

But don't let this stop you! If you've got specific ideas or improvements related to this topic, feel free to open new issues for each one. That way, we can dive into them in more detail.

@mattab mattab closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2023
@gausam
Copy link
Contributor

gausam commented Dec 10, 2023

@mattab well, you created this issue! 😁

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants