Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty translations string should default to english (Catalan translation is partially broken) #1003

Closed
mattab opened this issue Oct 12, 2009 · 12 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 12, 2009

From email:

If you go to piwik online demo and choose catalan language, piwik does not work correctly. Try to go , for exemple, to "referers" tab... You cannot.

I think the translation is bad-formed, I think some errors like characters like which are escaped ç , and that's because it doesn't work.

@robocoder
Copy link
Contributor

latest rev in svn worksforme.

matt: can you svn up piwik.org/demo-trunk ?

@mattab
Copy link
Member Author

mattab commented Oct 12, 2009

I updated demo-trunk and is broken too (look at Referers>Overview which doesn't load)

Note: we should update unit test to detect this broken use case.

@robocoder
Copy link
Contributor

In [1493], Add missing widget category name.

@robocoder
Copy link
Contributor

I think the proper fix is to eliminate the translation of the widget category name in Piwik_Add():

        $widgetCategory = Piwik_Translate($widgetCategory);

because many of the widget category names are neither translated nor translateable:

'Actions_Actions'
'Example Widgets'
'General_Visitors'
'GeoIP'
'Live!'
'Referers'
'UserSettings_VisitorSettings'
'Visits Summary'
'VisitTime_SubmenuTimes'

@robocoder
Copy link
Contributor

scratch that... I forgot category names are used in Widgetize.

@robocoder
Copy link
Contributor

p.s. to explain the bug/fix: because the translated string was "", json_encode (on piwik.org) discarded the UserSettings widgets when serializing. On my server, json_encode used "" for the widget category name.

@robocoder
Copy link
Contributor

In [1495], refs #1003; use translation strings for consistency

@mattab
Copy link
Member Author

mattab commented Oct 13, 2009

The translation manager should have used the english translation if the original translation string was "empty" - does your comment mean that this is not working as expected?

@robocoder
Copy link
Contributor

The translation manager uses the English string if the translation string is not defined (see array_merge). In the Catalan translation, it was defined as an empty string.

@mattab
Copy link
Member Author

mattab commented Oct 14, 2009

reopening it's a quick fix

@robocoder
Copy link
Contributor

In [1501], fixes #1003 - filter empty translations

@robocoder
Copy link
Contributor

In [1502], refix #1003

In [1503], refs #1003 - filter empty translations when counting percentage translated

@mattab mattab added this to the Piwik 0.4.4 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Critical Indicates the severity of an issue is very critical and the issue has a very high priority.
Projects
None yet
Development

No branches or pull requests

2 participants