Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process goal conversions for device data (type, brand, model) #10026

Closed
wants to merge 2 commits into from
Closed

Process goal conversions for device data (type, brand, model) #10026

wants to merge 2 commits into from

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 10, 2016

fixes #9777

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Apr 10, 2016
@mattab mattab added this to the 2.16.2 milestone Apr 10, 2016
tsteur
tsteur reviewed Apr 11, 2016
View reviewed changes
plugins/DevicesDetection/Columns/DeviceBrand.php
* @param Action|null $action
* @return mixed
*/
public function onAnyGoalConversion(Request $request, Visitor $visitor, $action)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattab this will add columns to log_conversion. So for the other dimensions. I presume it's maybe not as much of a major update to add these columns or shall we merge into Piwik 3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, there will three columns be added to log_conversion table. Can also rebase and recreate the pull request on 3.x

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to recreate PR against 3.x because of the schema change. Otherwise looks 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll reissue another PR for 3.x-dev branch so we can decide where to merge

@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Apr 15, 2016
@sgiehl sgiehl mentioned this pull request Apr 18, 2016
Merged
@sgiehl
Copy link
Member Author

sgiehl commented Apr 19, 2016

Can be closed if we decide to merge that in 3.x only.

@tsteur
Copy link
Member

tsteur commented Apr 19, 2016

Let's close this one. The actual issue is in mid term milestone anyway and ideally we issue all PRs against Piwik 3 first anyway. Especially when it's a new feature since Piwik 2 is in LTS

@tsteur tsteur closed this Apr 19, 2016
@sgiehl sgiehl deleted the devicegoalreports branch May 2, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
2.16.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @tsteur @mattab