Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply default filter_limit to all API calls #10009

Merged
merged 5 commits into from Aug 30, 2016
Merged

Apply default filter_limit to all API calls #10009

merged 5 commits into from Aug 30, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 5, 2016

fix #8458

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 5, 2016
@tsteur tsteur added this to the 3.0.0-b1 milestone Apr 5, 2016
@tsteur
Copy link
Member Author

tsteur commented Apr 5, 2016

FYI: The currently failing system and UI tests are not related to this change

@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Apr 5, 2016
@tsteur tsteur added c: Website matomo.org For issues related to our matomo.org website. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. and removed Needs Review PRs that need a code review labels Apr 6, 2016
@tsteur
Copy link
Member Author

tsteur commented Apr 8, 2016

The tests will be green after merging matomo-org/matomo-log-analytics#134 and updating submodule reference

@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Apr 8, 2016
@tsteur tsteur mentioned this pull request Aug 30, 2016
Closed
3 tasks
@tsteur tsteur merged commit 11491dd into 3.x-dev Aug 30, 2016
@tsteur tsteur deleted the 8458 branch August 30, 2016 22:43
tsteur added a commit that referenced this pull request Aug 31, 2016
@tsteur
Apply default filter_limit to all API calls (#10009)
860ae50 
* fix #8458 Apply default filter_limit to all API calls

* return all results where needed instead of default filter limit of 100

* make sure to apply offset

* fix unit tests

* fix import logs test as they post the filter value
tsteur added a commit that referenced this pull request Sep 1, 2016
@tsteur
Apply default filter_limit to all API calls (#10009)
73c0602 
* fix #8458 Apply default filter_limit to all API calls

* return all results where needed instead of default filter limit of 100

* make sure to apply offset

* fix unit tests

* fix import logs test as they post the filter value
tsteur added a commit that referenced this pull request Sep 1, 2016
@tsteur
Apply default filter_limit to all API calls (#10009)
fb91421 
* fix #8458 Apply default filter_limit to all API calls

* return all results where needed instead of default filter limit of 100

* make sure to apply offset

* fix unit tests

* fix import logs test as they post the filter value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Website matomo.org For issues related to our matomo.org website. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.

Apply default filter_limit to all API calls
1 participant
@tsteur