Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove magic quote hacks as now PHP 5.5 is required #10001

Merged
merged 1 commit into from Apr 8, 2016
Merged

Remove magic quote hacks as now PHP 5.5 is required #10001

merged 1 commit into from Apr 8, 2016

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 4, 2016

fixes #8012

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 4, 2016
@tsteur tsteur added this to the 3.0.0-b1 milestone Apr 4, 2016
@mattab
Copy link
Member

mattab commented Apr 4, 2016

you could remove this from the tests as well: https://github.com/piwik/piwik/blob/master/tests/PHPUnit/Unit/CommonTest.php#L105-L112

@tsteur
Copy link
Member Author

tsteur commented Apr 5, 2016

It's already removed in 3.x-dev

@mattab mattab merged commit ce4a113 into 3.x-dev Apr 8, 2016
@mattab mattab deleted the 8012 branch April 8, 2016 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.0.0-b1
Development

Successfully merging this pull request may close these issues.

Remove magic quote hacks before 3.0 is released
2 participants
@tsteur @mattab