Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sparklines error in Firefox 3.5.3, reload is not a function. #988

Closed
anonymous-matomo-user opened this issue Sep 17, 2009 · 7 comments
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Milestone

Comments

@anonymous-matomo-user
Copy link

The sparklines no longer update the flash chart. I'm not sure what the return type of findSWFGraph is supposed to be, but alert() says it's HTMLObjectElement.

Firebug error is:
piwikHelper.findSWFGraph(graph.attr("graphId") + "Chart_swf").reload is not a funciton.

I've tried unloading firebug and other addons to make sure it wasn't related to addons changing the javascript functionality.
Keywords: sparklines, reload, findSWFGraph

@robocoder
Copy link
Contributor

What Piwik version? What third party plugins? Any local customizations?

@robocoder
Copy link
Contributor

Odd. It works for me using FF3.0.x on the demo site.

@robocoder
Copy link
Contributor

Can you try deleting your browser cache? (Flash player reportedly also has a cache.) There was a bug in an older version of Open Flash Chart (V2J) that was fixed in V2K.

@robocoder
Copy link
Contributor

No feedback received.

@anonymous-matomo-user
Copy link
Author

It works for me too in FF 3.0, only in 3.5 does it fail.

I have tracked this down to a strange interaction with some firefox extensions and 3.5. On sites which use an embeded "embed" tag under the object tag which loads the flash, this bug is not reproducible. Only on sites which use pure "object" tags to load flash.

Although technically not a piwik bug, I imagine that a large number of piwik users use Firefox, and will upgrade to 3.5 at some point. I guess this could remain closed and the solution is, don't use Firefox with add-ons installed. If more users start noticing this, adding an "embed" tag might patch the upstream bug.

@robocoder
Copy link
Contributor

The HTMLObjectElement returned by findSWFGraph() is the expected return type. 'reload' is a function exported by open-flash-chart.swf.

We probably won't add an "embed" hack. We use swfobject which generates standards compliant tags for browsers that support it. We'll revisit this when we update jquery -- it's one of the UI regression tests.

@anonymous-matomo-user anonymous-matomo-user added this to the Piwik 0.4.4 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

2 participants