Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zend_Db adapterNamespace #979

Closed
robocoder opened this issue Sep 11, 2009 · 1 comment
Closed

Zend_Db adapterNamespace #979

robocoder opened this issue Sep 11, 2009 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@robocoder
Copy link
Contributor

Zend_Db allows an 'adapterNamespace' to be specified. This would allow us to remove core/Db.php (Piwik_Db::factory) and go back to using Zend_Db::factory.

Changes:

  • config/global.ini.php and config/config.ini.php.sample
  • plugins/Installation/Controller.php
  • core/Piwik.php

Remove:

  • core/Db.php

Update script:

  • add adapterNamespace to config/config.ini.php
  • alternative is to set this at runtime
@robocoder
Copy link
Contributor Author

Let's not change this for now. The extra abstraction may help others in porting Piwik to other databases (e.g., Postgresql).

@robocoder robocoder added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robocoder