Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS warnings, errors, and ugliness #946

Closed
robocoder opened this issue Aug 23, 2009 · 10 comments
Closed

CSS warnings, errors, and ugliness #946

robocoder opened this issue Aug 23, 2009 · 10 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
0.5

Comments

@robocoder
Copy link
Contributor

Firefox 3 reports errors in thickbox.css, jquery-calendar.css, common.css, and dashboard.css. (Latter two are Piwik-specific.)

Canoo webtest reports warnings/errors in: index.php, dashboard.css, thickbox.css, and jquery-calendar.css.

CoreHome embeds a <style> section in the <body> for tagclouds. This should be moved to a separate .css file, and included via <link> in the <head>. The rules also need to be tightened up a bit, e.g.,

.word a {
  text-decoration:none;
}

should be:

#tagCloud .word a {
  text-decoration:none;
}
@robocoder
Copy link
Contributor Author

Attachment:
CssErrors.txt

@robocoder
Copy link
Contributor Author

See also #905 and http://forum.piwik.org/index.php?showtopic=1463

@robocoder
Copy link
Contributor Author

files with embedded styles:

  • ./API/templates/listAllAPI.tpl
  • ./CoreHome/templates/cloud.tpl
  • ./Feedback/templates/index.tpl
  • ./Feedback/templates/sent.tpl
  • ./Goals/templates/form_add_goal.tpl
  • ./Goals/templates/single_goal.tpl
  • ./Installation/templates/displayJavascriptCode.tpl
  • ./Installation/templates/structure.tpl
  • ./Installation/templates/systemCheck.tpl
  • ./Live/templates/index.tpl
  • ./SitesManager/templates/DisplayJavascriptCode.tpl
  • ./SitesManager/templates/SitesManager.tpl
  • ./UsersManager/templates/UsersManager.tpl
  • ./Widgetize/templates/index.tpl

@robocoder
Copy link
Contributor Author

In [1558], refs #510, refs #946 - remove sortable helper class (no longer used)

@robocoder
Copy link
Contributor Author

In [1559], refs #946 - fix css errors

@robocoder
Copy link
Contributor Author

deferring jquery-calendar.css to #680, and thickbox.css to #1029

@robocoder
Copy link
Contributor Author

In [1560], refs #946 - plugins/API : move embedded style to external stylesheet

@robocoder
Copy link
Contributor Author

In [1561], refs #946 - plugins/CoreHome - tag cloud css cleanup

@robocoder
Copy link
Contributor Author

In [1562], refs #946 - cloud.css

@robocoder
Copy link
Contributor Author

Fixed for now. Re-think the reorg for #660.

@robocoder robocoder added this to the Piwik 0.5 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@robocoder