Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix The Netherlands on the map #9170

Open
Tralapo opened this issue Nov 5, 2015 · 10 comments
Open

Fix The Netherlands on the map #9170

Tralapo opened this issue Nov 5, 2015 · 10 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@Tralapo
Copy link

Tralapo commented Nov 5, 2015

The visitor map in Piwik isn't very accurate and I'm fine with that, but you guys are quite far off with The Netherlands. It's true we do claim land from water sometimes, but in Piwik it's quite extreme. The 'IJsselmeer', a big lake in the middle of the country, has been turned into land in the Piwik Map.

Not a big priority I would say, but would be good to look at.

Piwik:
Piwik

Actual Netherlands:
kaart nederland met provincies

@tsteur
Copy link
Member

tsteur commented Nov 5, 2015

I tried to find out if this is fixed with latest Kartograph version ( https://github.com/kartograph/kartograph.js ) but couldn't find a demo. Does anyone know where we get updated SVG files? It seems like they are not in the kartograph project itself

@sgiehl
Copy link
Member

sgiehl commented Nov 5, 2015 via email

@tsteur
Copy link
Member

tsteur commented Nov 5, 2015

Yep seems somehow broken, already fails when trying to download some ZIP files

@sgiehl
Copy link
Member

sgiehl commented Nov 5, 2015 via email

@tsteur
Copy link
Member

tsteur commented Nov 5, 2015

Wow, cool. Let me know if you get it working or need any help. Maybe we can also contact @gka if we don't get it to work

@sgiehl
Copy link
Member

sgiehl commented Nov 5, 2015

Tried that in February... Didn't get it working proper and @gka didn't respond. See #321

@gka
Copy link
Contributor

gka commented Nov 10, 2015

the map is not "wrong", it's just a matter wether or not the interior lakes are being cut-out.

As for the Piwik map I think we used NaturalEarth adm_level1_10m shapefiles as input data, in which the Netherlands happen to look like this.

image

To fix it, just add a custom shapefile for the Netherlands in the custom folder and it'll be used instead of the NE shapefile.

@gka
Copy link
Contributor

gka commented Nov 10, 2015

btw, I moved the repo to piwik/piwik-map-generator to make it easier for everyone to maintain it.

@sgiehl
Copy link
Member

sgiehl commented Nov 10, 2015

@gka do you have some time to adjust the repo so it works again? Guess the urls needs to be adjusted

@mattab
Copy link
Member

mattab commented Nov 25, 2015

Hi @gka, thanks for moving the project to the repo!

@mattab mattab added this to the Mid term milestone Nov 25, 2015
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Nov 25, 2015
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

5 participants