New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix The Netherlands on the map #9170
Comments
I tried to find out if this is fixed with latest Kartograph version ( https://github.com/kartograph/kartograph.js ) but couldn't find a demo. Does anyone know where we get updated SVG files? It seems like they are not in the kartograph project itself |
Afaik they were built using https://github.com/gka/piwik-map-generator
Tried to fork and rebuild them once, but didn't get it running proper...
|
Yep seems somehow broken, already fails when trying to download some ZIP files |
Tried to fixed that... See https://github.com/sgiehl/piwik-map-generator
|
Wow, cool. Let me know if you get it working or need any help. Maybe we can also contact @gka if we don't get it to work |
the map is not "wrong", it's just a matter wether or not the interior lakes are being cut-out. As for the Piwik map I think we used NaturalEarth adm_level1_10m shapefiles as input data, in which the Netherlands happen to look like this. To fix it, just add a custom shapefile for the Netherlands in the |
btw, I moved the repo to piwik/piwik-map-generator to make it easier for everyone to maintain it. |
@gka do you have some time to adjust the repo so it works again? Guess the urls needs to be adjusted |
Hi @gka, thanks for moving the project to the repo! |
The visitor map in Piwik isn't very accurate and I'm fine with that, but you guys are quite far off with The Netherlands. It's true we do claim land from water sometimes, but in Piwik it's quite extreme. The 'IJsselmeer', a big lake in the middle of the country, has been turned into land in the Piwik Map.
Not a big priority I would say, but would be good to look at.
Piwik:
Actual Netherlands:
The text was updated successfully, but these errors were encountered: