Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Odd/Even class of datatable to use smarty cycle? #914

Closed
pebosi opened this issue Aug 10, 2009 · 4 comments
Closed

Switch Odd/Even class of datatable to use smarty cycle? #914

pebosi opened this issue Aug 10, 2009 · 4 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@pebosi
Copy link
Contributor

pebosi commented Aug 10, 2009

Hi,

why not removing the js code from datatable.js which adds even odd classes and use smarty's cycle method?

regards

@robocoder
Copy link
Contributor

I haven't looked into this. Can you create a patch?

@mattab
Copy link
Member

mattab commented Aug 13, 2009

Hey Pebosi,
please create a patch when submitting feedback on small details of code - it is more likely to be fixed :)

@robocoder
Copy link
Contributor

Attachment:
914.patch

@robocoder
Copy link
Contributor

Deferring this change.

This patch bucks the trend by shifting processing back to the server while newer browsers come out with higher performance JavaScript engines.

Plus, it makes the code less readable...

@pebosi pebosi added this to the Piwik 0.6.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants