Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

angular tests for angular dialog service #9023

Open
mattab opened this issue Oct 16, 2015 · 5 comments
Open

angular tests for angular dialog service #9023

mattab opened this issue Oct 16, 2015 · 5 comments
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Oct 16, 2015

follows up #9012 Dialogs implemented with angular will not display on reload or via URL

TODO:

  • Add some angular tests for angular dialog service.
  • Maybe add a UI test for the service w/ a dummy dialog directive.
@mattab mattab added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Oct 16, 2015
@mattab mattab mentioned this issue Oct 16, 2015
Merged
2 tasks
@diosmosis diosmosis added this to the 2.15.1 milestone Oct 16, 2015
@diosmosis diosmosis self-assigned this Oct 16, 2015
@tsteur
Copy link
Member

tsteur commented Oct 16, 2015

Does it make sense to use angular tests for this? A ui test sounds more appropriate but am not into it what the problem was

@diosmosis
Copy link
Member

I just want to add complete coverage without adding too many ui tests.

@tsteur
Copy link
Member

tsteur commented Oct 17, 2015

Just wondering how you make sure it's displayed? Check for a certain css class? Is it possible to trigger a reload of a page in the tests? Cause I thought angular tests are supposed to be unit tests, so curious if that's possible.

@diosmosis
Copy link
Member

I haven't really thought about it. To clarify, I don't want to add 0 UI tests, just one or two UI tests, and then get full coverage via an angular test (instead of adding 10 extra UI tests or something).

@tsteur
Copy link
Member

tsteur commented Oct 17, 2015

👍 sounds good :) I only read the issue description and what was wondering about it

@mattab mattab modified the milestones: 2.15.1, 3.0.0 Oct 20, 2015
@mattab mattab modified the milestones: Long term, 3.0.0 Feb 8, 2016
@mattab mattab added Lower priority and removed not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Dec 5, 2016
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
This was referenced Dec 1, 2023
Open
Open
@sirinartk sirinartk mentioned this issue Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
3 participants
@diosmosis @tsteur @mattab